Add methods to retrieve noise parameters for WebGL shaders #8162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8160
Changes
Added support for
noiseDetail()in p5.strands shaders:src/math/noise.js: Added two private getter functions_getNoiseOctaves()- Returns current octaves value_getNoiseAmpFalloff()- Returns current falloff valuesrc/webgl/p5.RendererGL.js: Added noise uniforms to all default shadersuNoiseOctaves(int) anduNoiseAmpFalloff(float) uniformsHow It Works
When
noiseDetail()is called, the values are now automatically passed to shaders as uniforms. This allows p5.strands to implement GLSL noise functions that use the current noise detail settings instead of hardcoded values.PR Checklist
npm run lintpasses