Add unit tests for log_broken and update_contribution in fetch_update… #90
Conversation
…s.py - Added tests for log_broken() and update_contribution() in tests/test_fetch_updates.py - Ensured both functions behave correctly with expected contribution input - Removed unused mocks and patch decorators - Verified tests pass using pytest
✅ Deploy Preview for processing-contributions ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Thanks for this - there are just some cosmetic changes that should be changed first before I review the actual content. In general, don't change the formatting so drastically unless that is the point of the work, thanks.
Also, please remove the pycache folders and their contents from this PR.
Many thanks.
| contribution['previousVersions'] = [] | ||
| contribution['previousVersions'].append(contribution['prettyVersion']) | ||
|
|
||
| # update from online |
There was a problem hiding this comment.
Please leave in the comments that were previously there.
| contribution[field] = [] | ||
| else: | ||
| contribution[field] = props[field] | ||
| datetime_today = datetime.now(UTC).strftime('%Y-%m-%dT%H:%M:%S%z') |
There was a problem hiding this comment.
apologies, this comment didn't get added to the previous review:
Also, please revert the formatting and spacing to the previous formatting, since it masks the true changes that have been made. You might need to change your editor to the settings of the current file.
Fixed Issue #85
Fixed all and unit tested
Only 2 changes have been made added tests and rectified few parts of fetch_updates.py code. Rests are unchanged, showing 9 files due to multiple experimentation in vscode but all other codes remain unchanged.
Now you can cleanly merge.
