Skip to content

Fix the issue with the pre-processor test #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

Fix the issue with the pre-processor test #1236

merged 1 commit into from
Sep 12, 2025
+1 −8

Conversation

Stefterv
Copy link
Collaborator

Upgrading the preprocessor made it no longer recognise the quicktime keyword in the bug1532.pde causing the test to fail. As far as I can see this test was never intended to test for that situation but rather for some invalid syntax later on line 50 of that file.

I cannot find anything about the quicktime keyword so I have just commented out the line with the new issue

@Stefterv Stefterv requested a review from catilac September 10, 2025 06:03
@Stefterv
Copy link
Collaborator Author

@SableRaf and I should do some archeological research into bug 1532 on the bugzilla archives

@SableRaf
Copy link
Collaborator

SableRaf commented Sep 10, 2025 •
edited
Loading

@Stefterv Bug 1532 can be found at https://bugzilla.processing.org/1532

catilac
catilac reviewed Sep 11, 2025
View reviewed changes
catilac
catilac requested changes Sep 11, 2025
View reviewed changes
Copy link
Collaborator

@catilac catilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good, please remove the unused code and update the test

@Stefterv
Update bug1532 test and resource file
9507241 
Adjusted expected exception position in ParserTests for bug1532 and removed QuickTime session initialization from bug1532.pde to reflect updated test requirements.
@Stefterv Stefterv requested a review from catilac September 12, 2025 05:47
catilac
catilac approved these changes Sep 12, 2025
View reviewed changes
Copy link
Collaborator

@catilac catilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Stefterv!

@catilac catilac merged commit 354e560 into processing:main Sep 12, 2025
6 checks passed
Stefterv added a commit to Stefterv/processing4 that referenced this pull request Sep 22, 2025
@Stefterv
Squashed commit of the following:
bae6533 
commit b2f79f6
Author: Stef Tervelde <[email protected]>
Date:   Mon Sep 22 14:21:27 2025 +0200

    Include root-level Java files in source set

    Uncommented and updated the configuration to include all .java files at the project root in the source set. This ensures that Java files located directly in the project directory are recognized and compiled.

commit 4aeff01
Merge: 046a216 72db9b7
Author: Stef Tervelde <[email protected]>
Date:   Mon Sep 22 14:07:25 2025 +0200

    Merge branch 'main' into gradle-runner

commit 72db9b7
Merge: 0c43ebf aa9fd93
Author: Moon <[email protected]>
Date:   Fri Sep 19 08:24:30 2025 -0400

    Merge pull request processing#1251 from Stefterv/lsp-libraries-fix

    Make sure LSP recognises contributed libraries

commit aa9fd93
Author: Stef Tervelde <[email protected]>
Date:   Fri Sep 19 11:19:37 2025 +0200

    Make sure contributions are loaded in the lsp

    Trigger locating the sketchbook folder so contributed libraries are loaded

commit 0c43ebf
Merge: 9ca92bc 5a108da
Author: Moon <[email protected]>
Date:   Thu Sep 18 09:01:09 2025 -0400

    Merge pull request processing#1248 from processing/all-contributors/add-SuganthiThomas

    docs: add SuganthiThomas as a contributor for code

commit 5a108da
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu Sep 18 13:00:49 2025 +0000

    docs: update .all-contributorsrc [skip ci]

commit f3198d7
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu Sep 18 13:00:48 2025 +0000

    docs: update README.md [skip ci]

commit 9ca92bc
Merge: 13e6977 88b9e04
Author: Moon <[email protected]>
Date:   Thu Sep 18 08:54:28 2025 -0400

    Default DEBUG env value to false, or read actual value instead of only checking for existence

commit 88b9e04
Author: Suganthi Thomas <[email protected]>
Date:   Wed Sep 17 22:12:07 2025 -0500

    Removed commented lines

commit 014fd93
Author: Suganthi Thomas <[email protected]>
Date:   Tue Sep 16 17:43:01 2025 -0500

    DEBUG should be set to the actual value.

commit 13e6977
Merge: bdbd025 a741775
Author: Stef Tervelde <[email protected]>
Date:   Tue Sep 16 09:12:10 2025 +0200

    Merge pull request processing#1239 from Stefterv/develop-menu

    Add 'Develop' menu for debug mode with update check

commit a741775
Author: Stef Tervelde <[email protected]>
Date:   Fri Sep 12 21:51:13 2025 +0200

    Added Language key for `menu.develop.check_for_updates`

commit bdbd025
Merge: 354e560 9b44035
Author: Moon <[email protected]>
Date:   Fri Sep 12 14:30:06 2025 -0400

    Merge pull request processing#1242 from processing/all-contributors/add-npNSU

    docs: add npNSU as a contributor for code

commit 9b44035
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Fri Sep 12 18:26:32 2025 +0000

    docs: update .all-contributorsrc [skip ci]

commit 2800725
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Fri Sep 12 18:26:31 2025 +0000

    docs: update README.md [skip ci]

commit c3b2c6b
Merge: d3f3611 354e560
Author: Stef Tervelde <[email protected]>
Date:   Fri Sep 12 17:54:13 2025 +0200

    Merge branch 'processing:main' into develop-menu

commit 354e560
Merge: 2c94b38 9507241
Author: Moon <[email protected]>
Date:   Fri Sep 12 11:50:16 2025 -0400

    Merge pull request processing#1236 from Stefterv/main

    Fix the issue with the pre-processor test

commit 2c94b38
Merge: 34a85df 4495cc5
Author: Moon <[email protected]>
Date:   Fri Sep 12 10:54:55 2025 -0400

    Merge pull request processing#1192 from npNSU/dxfMigration

    Migration of the `dxf` library from Ant to Gradle

commit 4495cc5
Merge: 20425fd 34a85df
Author: Moon <[email protected]>
Date:   Fri Sep 12 10:39:45 2025 -0400

    Merge branch 'main' into dxfMigration

commit 34a85df
Merge: 2e855a1 3fbfddb
Author: Stef Tervelde <[email protected]>
Date:   Fri Sep 12 15:34:22 2025 +0200

    Merge pull request processing#1222 from hamoid/addDependencyUpdates

    Add Gradle task to check for dependency updates

commit 2e855a1
Merge: 275d789 3814307
Author: Raphaël de Courville <[email protected]>
Date:   Fri Sep 12 14:43:31 2025 +0200

    Merge pull request processing#1226 from Stefterv/pixel-density-warning

    Add warning for default pixelDensity behavior

commit 3814307
Author: Raphaël de Courville <[email protected]>
Date:   Fri Sep 12 14:42:36 2025 +0200

    Update the warning message for pixelDensity

    Made the warning message more helpful

commit 9507241
Author: Stef Tervelde <[email protected]>
Date:   Fri Sep 12 07:46:40 2025 +0200

    Update bug1532 test and resource file

    Adjusted expected exception position in ParserTests for bug1532 and removed QuickTime session initialization from bug1532.pde to reflect updated test requirements.

commit 3fbfddb
Merge: 0e18502 275d789
Author: Stef Tervelde <[email protected]>
Date:   Thu Sep 11 16:09:43 2025 +0200

    Merge branch 'main' into addDependencyUpdates

commit d3f3611
Author: Stef Tervelde <[email protected]>
Date:   Thu Sep 11 16:02:49 2025 +0200

    Add 'Develop' menu for debug mode with update check

    Introduces a new 'Develop' menu that appears when debug mode is enabled.

commit 0e18502
Author: Abe Pazos <[email protected]>
Date:   Thu Sep 11 14:09:19 2025 +0200

    Gradle libs.versions.toml: inline "versions" version

commit 275d789
Merge: 11ba3b4 faf5997
Author: Moon <[email protected]>
Date:   Tue Sep 9 15:03:41 2025 -0400

    Merge pull request processing#1189 from Stefterv/fix-pdf-library

    Migration of the `pdf` library to Gradle

commit 11ba3b4
Merge: 43ba46b 00e4243
Author: Moon <[email protected]>
Date:   Tue Sep 9 15:02:51 2025 -0400

    Merge pull request processing#1232 from Stefterv/gradle-runner-preproc

    Moving the `java:preprocessor` to be fully Gradle native

commit 43ba46b
Merge: c570b6d 7e109bd
Author: Moon <[email protected]>
Date:   Tue Sep 9 15:01:52 2025 -0400

    Merge pull request processing#1228 from Stefterv/format-cli

    Adding the sketch format command

commit c570b6d
Merge: e56e281 8f418a2
Author: Moon <[email protected]>
Date:   Mon Sep 8 14:41:47 2025 -0400

    Merge pull request processing#1227 from awood0727/debugFixUpdate

    Updated fix for the debugger issue

commit 8f418a2
Author: Amante' Woodley <[email protected]>
Date:   Fri Sep 5 09:53:39 2025 -0400

    Updated fix for the dubugger issue

    Signed-off-by: Amante' Woodley <[email protected]>

    Co-authored-by: Nia Perez <[email protected]>
    Co-authored-by: Kayla Bobo <[email protected]>
    Co-authored-by: Silas Morgan <[email protected]>

commit 7e109bd
Author: Stef Tervelde <[email protected]>
Date:   Fri Sep 5 14:28:03 2025 +0200

    Adding the sketch format command

commit 906ab17
Author: Stef Tervelde <[email protected]>
Date:   Thu Sep 4 10:34:45 2025 +0200

    Add warning for default pixelDensity behavior

    Introduces a warning message when pixelDensity defaults to 2x to match the display's pixel density. The warning prompts users to explicitly set pixelDensity in settings() to avoid the message.

commit 452fbce
Author: Abe Pazos <[email protected]>
Date:   Sat Aug 30 00:15:17 2025 +0200

    Add Gradle task to check for dependency updates

commit 20425fd
Author: [Nia Perez] <[email protected]>
Date:   Mon Jul 28 14:30:12 2025 -0400

    Worked on migration of the dxf library from Ant to Gradle

    Signed-off-by: [Nia Perez] <[email protected]>

    Co-authored-by: Amante' Woodley <[email protected]>
    Co-authored-by: Kayla Bobo <[email protected]>
    Co-authored-by: Silas Morgan <[email protected]>

commit faf5997
Author: Stef Tervelde <[email protected]>
Date:   Wed Jul 23 06:58:14 2025 +0200

    Migration of the `pdf` library to Gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catilac catilac catilac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stefterv @SableRaf @catilac