Add --main flag to support sketches with different main .pde files
#1263
+49
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying a custom main .pde file when running Processing sketches from the command line, allowing users to override the default naming convention that requires the main file to match the folder name.
- Adds a new
--maincommand-line argument to specify custom main .pde files - Implements validation to ensure the specified file has a .pde extension and exists within the sketch folder
- Refactors the main file discovery logic to support both default and custom naming patterns
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // No extension or dot at end (e.g., "file" or "file.") | ||
| complainAndQuit("The main file must be a .pde file.", true); | ||
| } | ||
| String extension = mainFilename.substring(dotIndex + 1).toLowerCase(Locale.ENGLISH); |
There was a problem hiding this comment.
[nitpick] The file extension validation logic should be extracted into a separate method to improve readability and reusability. Consider creating a validatePdeExtension(String filename) helper method.
Copilot uses AI. Check for mistakes.
hxrshxz
changed the title
--main flag to support sketches with different main .pde files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CLI previously required sketches to follow strict naming convention where the main
.pdefile must match the folder name. This PR adds--main=<file>flag to support sketches with different main file names.