-
-
Notifications
You must be signed in to change notification settings - Fork 103
pr05 Visual Regression Testing #2: Adding More Tests #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vaivaswat2244
wants to merge
40
commits into
processing:visual-testing
Choose a base branch
from
Vaivaswat2244:more-visual-tests
base: visual-testing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
pr05 Visual Regression Testing #2: Adding More Tests #1315
Vaivaswat2244
wants to merge
40
commits into
processing:visual-testing
from
Vaivaswat2244:more-visual-tests
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated README to reflect migration to Jetpack Compose and strategy for replacing JEditTextArea with RSyntaxTextArea. Added insights on LSP-based editor research and the need for user feedback on Tweak Mode and autocompletion features.
This reverts commit 66071ac.
Add configuration for dependencyUpdates task to manage non-stable versions.
More details surrounding `JEditTextArea`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Visual Tests for Typography and Shape Modes
Summary
This PR adds comprehensive visual tests for two core Processing features:
Typography Tests
Tests cover:
Shape Modes Tests
Tests cover:
Known Issue
Arc rendering inconsistency: Arc tests are currently not generating screenshots as expected due to what I think might be a discrepancy in how Processing handles negative dimensions compared to p5.js.


For Processing the screenshot getting generated is
and for p5, same test generates image
In p5.js,
arc()converts negative width/height to absolute values while maintaining position. Processing'sarc()appears to handle this differently, causing some arcs not to render or render at incorrect positions. I would like some thoughts as to why this may be happening.