fix(cli): assign unique rollout instance IDs - #1002
Merged
ralyodio merged 1 commit intoAug 30, 2026
Merged
Conversation
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
ralyodio
added a commit
that referenced
this pull request
Aug 30, 2026
Lockstep bump of every published package. The six packages the cli depends on had drifted to 0.3.0 while the cli sat at 0.3.1; they are all 0.3.2 now, which is what the lockstep script exists to guarantee — pnpm rewrites `workspace:` to a real range at publish time, so anything the cli depends on has to reach the registry at a version that exists. Since v0.3.0: - threatcrush-scan pack pinned to @profullstack/threatcrush@0.11.5 with a reproduced SRI hash, pack 2.0.2 so the fleet re-syncs consumers (#1003) - unique rollout instance IDs (#1002) - cloud vault passphrase prompt no longer hangs on non-TTY stdin (#1001) - DNS config persisted in JSON mode (#1000) - netcup adapter shipped in the command tree (#969) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H3GDps1fD6ccfo93B3ePy1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multi-instance rollouts calculated every new ID against the unchanged original fleet. A three-instance blue-green rollout therefore persisted
inst-0004three times, corrupting fleet identity and the rollout record.Fix
Include instances already prepared in the current rollout when calculating the next ID.
Regression coverage
The new subprocess test executes a real three-instance blue-green rollout in an isolated home, reads the persisted fleet, and requires the new IDs to be
inst-0004,inst-0005, andinst-0006while preserving unrelated credentials.Verification
inst-0004,inst-0004,inst-0004before the fixinst-0004,inst-0005,inst-0006after the fixpnpm exec vitest run packages/cli/src/commands/scale.test.ts(59 passed)pnpm --filter @profullstack/sh1pt... buildpnpm --filter @profullstack/sh1pt typecheck