Skip to content

Cache nginx debs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jgallen23
Copy link

this will speed up deployment a bit

@jgallen23
Copy link
Author

ping :)

@ghost
Copy link

ghost commented Jun 20, 2014

Thanks for the PR, and apologies for the wait..

Is there a way to do the version check in a more automated fashion? i.e.:

  • Mark when apt-get update was last run as well as current version of nginx
  • If apt-get update wasn't run in the last $x (24h?), run it
  • Check if there's a newer version available (via apt-cache?) and download new packages

It would allow nginx to be updated automatically and not get stuck behind me/someone updating this buildpack or someone waiting for the a newer buildstep to be published

@jgallen23
Copy link
Author

yeah. I can look into that. I figured nginx isn't updated all that often, so it would be ok and worst case they could delete the cache directory on the box if they wanted latest.

@ghost
Copy link

ghost commented Jun 20, 2014

Hm, on second thought I'm OK with that.

Could you change lines 5-7 to be independent of versions? Something like $CACHEDIR/nginx_*.deb (etc) could work

@jgallen23
Copy link
Author

great idea. I'll make that change later today

@ghost
Copy link

ghost commented Jun 20, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant