-
Notifications
You must be signed in to change notification settings - Fork 13
Test against InspIRCd v4 instead of v3. #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d695724
to
751a6c5
Compare
I updated Atheme to use the Git version with a special 7.3-only runner (as is used for running Bahamut with Anope) so it should be fixed now [pending #316 being merged, and the tests passing after rebase]? |
Is Insp3 still supported? if yes, would it be easy to keep testing for it, like we do for Unreal 5? |
Its still supported until the end of the year, so not for much longer. |
pull_request: | ||
paths: | ||
- .github/workflows/test-devel_release.yml | ||
push: | ||
paths: | ||
- .github/workflows/test-devel_release.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does that do? https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-including-paths doesn't explain what happens when we reference a workflow file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means the devel workflows will be run when they're updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooh smart. Could you explain that in a comment in make_workflows.py
, because I won't remember that in three month
make | ||
make install | ||
atheme-7-3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a comment explaining why we need both Atheme 7.2 and 7.3?
v3 will be EOL at the end of the year and is only getting critical updates at this point.