Skip to content

Test against InspIRCd v4 instead of v3. #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SadieCat
Copy link
Contributor

@SadieCat SadieCat commented May 3, 2025

v3 will be EOL at the end of the year and is only getting critical updates at this point.

@SadieCat SadieCat force-pushed the inspircd-v4 branch 2 times, most recently from d695724 to 751a6c5 Compare August 1, 2025 14:35
@SadieCat
Copy link
Contributor Author

SadieCat commented Aug 1, 2025

I updated Atheme to use the Git version with a special 7.3-only runner (as is used for running Bahamut with Anope) so it should be fixed now [pending #316 being merged, and the tests passing after rebase]?

@progval
Copy link
Owner

progval commented Aug 2, 2025

Is Insp3 still supported? if yes, would it be easy to keep testing for it, like we do for Unreal 5?

@SadieCat
Copy link
Contributor Author

SadieCat commented Aug 2, 2025

Its still supported until the end of the year, so not for much longer.

Comment on lines +185 to +190
pull_request:
paths:
- .github/workflows/test-devel_release.yml
push:
paths:
- .github/workflows/test-devel_release.yml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does that do? https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-including-paths doesn't explain what happens when we reference a workflow file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means the devel workflows will be run when they're updated.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh smart. Could you explain that in a comment in make_workflows.py, because I won't remember that in three month

make
make install
atheme-7-3:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a comment explaining why we need both Atheme 7.2 and 7.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants