refactor(frontend): useEffectListener-ify <CanvasView> listeners - #739
Open
jaskfla wants to merge 9 commits into
Open
refactor(frontend): useEffectListener-ify <CanvasView> listeners#739jaskfla wants to merge 9 commits into
useEffectListener-ify <CanvasView> listeners#739jaskfla wants to merge 9 commits into
Conversation
jaskfla
force-pushed
the
use-event-listener
branch
4 times, most recently
from
June 10, 2026 01:21
1c1943c to
0dbdb4c
Compare
jaskfla
force-pushed
the
use-event-listener
branch
from
June 10, 2026 02:37
a13a3f8 to
aaaf8df
Compare
Rocked03
reviewed
Jun 10, 2026
Comment on lines
1296
to
-1332
| @@ -1308,7 +1285,6 @@ export default function CanvasView({ | |||
| zoom={zoom} | |||
| /> | |||
| )} | |||
|
|
|||
| <CanvasImageWrapper | |||
| aria-busy={isLaunching || isLoading} | |||
| ref={canvasImageWrapperRef} | |||
| @@ -1327,9 +1303,7 @@ export default function CanvasView({ | |||
| style={{ minWidth: canvas.width, minHeight: canvas.height }} | |||
| /> | |||
| </CanvasImageWrapper> | |||
|
|
|||
| <CanvasGrid zoom={zoom} hidden={!isGridVisible} /> | |||
|
|
|||
Collaborator
Author
There was a problem hiding this comment.
Yes, but the fix is to break it into smaller, composable parts!
# Conflicts: # packages/frontend/src/components/canvas/CanvasView.tsx
jaskfla
enabled auto-merge
June 10, 2026 10:10
# Conflicts: # packages/frontend/src/components/canvas/CanvasView.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.