-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log the outgoing write values and command payloads in MTRBaseDevice. #35699
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:more-logging-outgoing
Sep 21, 2024
Merged
Log the outgoing write values and command payloads in MTRBaseDevice. #35699
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:more-logging-outgoing
Sep 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtov-sfy,
jtung-apple,
kiel-apple and
kkasperczyk-no
September 20, 2024 16:20
pullapprove
bot
requested review from
younghak-hwang,
yufengwangca and
yunhanw-google
September 20, 2024 16:21
nivi-apple
reviewed
Sep 20, 2024
nivi-apple
previously approved these changes
Sep 20, 2024
PR #35699: Size comparison from be3c70a to 9d78909 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
dismissed
nivi-apple’s stale review
September 20, 2024 18:56
Making significant changes to the PR.
bzbarsky-apple
force-pushed
the
more-logging-outgoing
branch
from
September 20, 2024 19:08
acf2e5d
to
cc77ac6
Compare
woody-apple
approved these changes
Sep 20, 2024
kiel-apple
approved these changes
Sep 20, 2024
PR #35699: Size comparison from d63051a to cc77ac6 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Fast-tracking platform-specific change with platform owner review. |
nivi-apple
reviewed
Sep 20, 2024
nivi-apple
reviewed
Sep 20, 2024
nivi-apple
reviewed
Sep 20, 2024
nivi-apple
reviewed
Sep 20, 2024
nivi-apple
reviewed
Sep 20, 2024
nivi-apple
approved these changes
Sep 20, 2024
PR #35699: Size comparison from d63051a to f406699 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
force-pushed
the
more-logging-outgoing
branch
from
September 20, 2024 23:24
f406699
to
76b9375
Compare
PR #35699: Size comparison from 4842bfc to 76b9375 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
force-pushed
the
more-logging-outgoing
branch
from
September 21, 2024 02:51
76b9375
to
bc45d9e
Compare
PR #35699: Size comparison from 4842bfc to bc45d9e Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the outgoing write values and command payloads in MTRDevice/MTRBaseDevice.