-
Notifications
You must be signed in to change notification settings - Fork 83
Add CASE session initiator (Sigma1/Sigma2/Sigma3) #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3ba3d56
Add CASE session initiator behind case-initiator feature
jonlil 354383c
ci: retrigger
jonlil cdb75da
Fix CASE initiator: derive IPK operational key from epoch key
jonlil c7947bb
Make compute_compressed_fabric_id public for CASE initiator use
jonlil e735fad
Fix import formatting (cargo fmt)
jonlil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -660,7 +660,7 @@ impl Fabric { | |
| } | ||
|
|
||
| /// Compute the compressed fabric ID | ||
| pub(crate) fn compute_compressed_fabric_id<C: Crypto>( | ||
| pub fn compute_compressed_fabric_id<C: Crypto>( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary if the |
||
| crypto: C, | ||
| root_pubkey: CanonPkcPublicKeyRef<'_>, | ||
| fabric_id: u64, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you positive that the LLM is not hallucinating the code/flash size increase? The equivalent PR #410 shows 0% code-size increase even though its code is not hidden behind a feature.