Estincelle case initiator#410
Merged
Merged
Conversation
generate ephemeral initiator ID for unsecured sessions
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the initiator side of the CASE protocol, allowing controllers to establish secure sessions. It refactors the CASE implementation into separate initiator and responder modules, adds cryptographic helpers for Sigma message processing, and updates the transport layer to support ephemeral initiator node IDs. Review feedback highlights concerns regarding large stack allocations within asynchronous functions in the initiator, which could lead to excessive memory usage or stack overflows on resource-constrained devices.
|
PR #410: Size comparison from 2af46c4 to 147b09f Full report (8 builds for (core), dimmable-light, onoff-light, onoff-light-bt, speaker)
|
3bc8d9d to
70ad900
Compare
|
PR #410: Size comparison from 2af46c4 to 70ad900 Full report (8 builds for (core), dimmable-light, onoff-light, onoff-light-bt, speaker)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR in the Estincelle repo, opened as a PR against
rs-matterupsream, and fixed to work with the latestrs-matterAPI.Closes #371