Skip to content

Estincelle case initiator#410

Merged
ivmarkov merged 5 commits into
project-chip:mainfrom
sysgrok:estincelle-case-initiator
Apr 15, 2026
Merged

Estincelle case initiator#410
ivmarkov merged 5 commits into
project-chip:mainfrom
sysgrok:estincelle-case-initiator

Conversation

@ivmarkov
Copy link
Copy Markdown
Contributor

@ivmarkov ivmarkov commented Apr 13, 2026

This PR in the Estincelle repo, opened as a PR against rs-matter upsream, and fixed to work with the latest rs-matter API.

Closes #371

marko655 and others added 3 commits April 13, 2026 10:50
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the initiator side of the CASE protocol, allowing controllers to establish secure sessions. It refactors the CASE implementation into separate initiator and responder modules, adds cryptographic helpers for Sigma message processing, and updates the transport layer to support ephemeral initiator node IDs. Review feedback highlights concerns regarding large stack allocations within asynchronous functions in the initiator, which could lead to excessive memory usage or stack overflows on resource-constrained devices.

Comment thread rs-matter/src/sc/case/initiator.rs Outdated
Comment thread rs-matter/src/sc/case/initiator.rs
@ivmarkov ivmarkov marked this pull request as ready for review April 13, 2026 11:33
@github-actions
Copy link
Copy Markdown

PR #410: Size comparison from 2af46c4 to 147b09f

Full report (8 builds for (core), dimmable-light, onoff-light, onoff-light-bt, speaker)
platform target config section 2af46c4 147b09f change % change
(core) riscv32imac-unknown-none-elf infodefmt-optz-ltofat FLASH 403870 403960 90 0.0
RAM 68072 68072 0 0.0
thumbv6m-none-eabi infodefmt-optz-ltofat FLASH 337860 338016 156 0.0
RAM 64312 64312 0 0.0
thumbv7em-none-eabi infodefmt-optz-ltofat FLASH 312748 312848 100 0.0
RAM 63800 63808 8 0.0
x86_64-unknown-linux-gnu infologs-optz-ltofat FLASH 839687 839807 120 0.0
RAM 66616 66616 0 0.0
dimmable-light x86_64-unknown-linux-gnu infologs-optz-ltofat FLASH 1957576 1958048 472 0.0
RAM 52352 52352 0 0.0
onoff-light x86_64-unknown-linux-gnu infologs-optz-ltofat FLASH 1890784 1891216 432 0.0
RAM 52056 52056 0 0.0
onoff-light-bt x86_64-unknown-linux-gnu infologs-optz-ltofat FLASH 3218056 3216904 -1152 -0.0
RAM 5784 5784 0 0.0
speaker x86_64-unknown-linux-gnu infologs-optz-ltofat FLASH 850424 850424 0 0.0
RAM 2856 2856 0 0.0

@ivmarkov ivmarkov force-pushed the estincelle-case-initiator branch from 3bc8d9d to 70ad900 Compare April 13, 2026 13:33
@github-actions
Copy link
Copy Markdown

PR #410: Size comparison from 2af46c4 to 70ad900

Full report (8 builds for (core), dimmable-light, onoff-light, onoff-light-bt, speaker)
platform target config section 2af46c4 70ad900 change % change
(core) riscv32imac-unknown-none-elf infodefmt-optz-ltofat FLASH 403870 403960 90 0.0
RAM 68072 68072 0 0.0
thumbv6m-none-eabi infodefmt-optz-ltofat FLASH 337860 338016 156 0.0
RAM 64312 64312 0 0.0
thumbv7em-none-eabi infodefmt-optz-ltofat FLASH 312748 312848 100 0.0
RAM 63800 63808 8 0.0
x86_64-unknown-linux-gnu infologs-optz-ltofat FLASH 839687 839807 120 0.0
RAM 66616 66616 0 0.0
dimmable-light x86_64-unknown-linux-gnu infologs-optz-ltofat FLASH 1957576 1958048 472 0.0
RAM 52352 52352 0 0.0
onoff-light x86_64-unknown-linux-gnu infologs-optz-ltofat FLASH 1890784 1891216 432 0.0
RAM 52056 52056 0 0.0
onoff-light-bt x86_64-unknown-linux-gnu infologs-optz-ltofat FLASH 3218056 3216904 -1152 -0.0
RAM 5784 5784 0 0.0
speaker x86_64-unknown-linux-gnu infologs-optz-ltofat FLASH 850424 850424 0 0.0
RAM 2856 2856 0 0.0

@ivmarkov ivmarkov merged commit 4fda1dd into project-chip:main Apr 15, 2026
14 checks passed
@ivmarkov ivmarkov deleted the estincelle-case-initiator branch April 19, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance CASE (case.rs) with support for session negotiation initiation

2 participants