Change pv mount path, change rollout strategy

[bsquizz]

Summary by Sourcery

Update PostgreSQL deployment configuration for kessel-relations to adjust rollout behavior and data storage paths.

Enhancements:

• Set the PostgreSQL Deployment strategy to Recreate to avoid overlapping pods during updates.
• Change the PostgreSQL data directory and corresponding volume mount from a temporary path to the standard /var/lib/pgsql/data persistent location.

[app-sre-bot]

Can one of the admins verify this patch?

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the PostgreSQL deployment to use a new persistent volume mount path and ensures pods are rolled out using a Recreate deployment strategy.

File-Level Changes

Change	Details	Files
Set the PostgreSQL Deployment rollout strategy to Recreate to avoid overlapping pods during updates.	Add a strategy section under the Deployment spec. Configure the strategy type to Recreate.	deploy/kessel-relations.yaml
Update PostgreSQL data directory and corresponding volume mount path to the standard location.	Change PGDATA environment variable value from /temp/data to /var/lib/pgsql/data. Change the volumeMounts.mountPath for the postgres-data volume from /temp/data to /var/lib/pgsql/data.	deploy/kessel-relations.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Switching the Deployment strategy to Recreate will cause downtime on every rollout; confirm this is acceptable for the service and, if not, consider using a RollingUpdate with appropriate podDisruptionBudget and readiness settings instead.
• Changing PGDATA and the volume mountPath to /var/lib/pgsql/data will effectively move the data directory; verify that the existing PVC contents are compatible with this new path or plan/automate a one-time data migration to avoid data loss or startup failures.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Switching the Deployment strategy to `Recreate` will cause downtime on every rollout; confirm this is acceptable for the service and, if not, consider using a `RollingUpdate` with appropriate podDisruptionBudget and readiness settings instead.
- Changing `PGDATA` and the volume `mountPath` to `/var/lib/pgsql/data` will effectively move the data directory; verify that the existing PVC contents are compatible with this new path or plan/automate a one-time data migration to avoid data loss or startup failures.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Rajagopalan-Ranganathan]

/lgtm