Skip to content

RHCLOUD-43676 add hccp01 cluster to dashboard#840

Merged
akoserwal merged 1 commit intoproject-kessel:mainfrom
akoserwal:RHCLOUD-43676-add-cluster-observ
Mar 9, 2026
Merged

RHCLOUD-43676 add hccp01 cluster to dashboard#840
akoserwal merged 1 commit intoproject-kessel:mainfrom
akoserwal:RHCLOUD-43676-add-cluster-observ

Conversation

@akoserwal
Copy link
Contributor

@akoserwal akoserwal commented Mar 9, 2026

PR Template:

Describe your changes

https://issues.redhat.com/browse/RHCLOUD-43676

  • ...

Ticket reference (if applicable)

Fixes #

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

Summary by Sourcery

Enhancements:

  • Extend the Grafana datasource regex to include the hccp01ue1 Prometheus instance for the Kessel Relations API dashboard.

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 9, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Kessel - Relations API Grafana dashboard to include the new hccp01ue1 Prometheus cluster in the datasource selection and bumps the dashboard version metadata accordingly.

File-Level Changes

Change Details Files
Extend Grafana dashboard datasource regex to allow selecting the new hccp01ue1 Prometheus cluster and bump the dashboard version.
  • Add hccp01ue1-prometheus to the allowed Prometheus datasources regex in the dashboard configuration
  • Increment the Kessel - Relations API dashboard version field from 9 to 10 to reflect the configuration change
dashboards/grafana-dashboard-kessel-relations-api.configmap.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The datasource regex is becoming long and error‑prone to maintain; consider simplifying it (e.g., using a shared prefix/suffix pattern or a character class for cluster identifiers) so new clusters can be added with less duplication.
  • When updating the dashboard version, it can help to note the reason for the bump (e.g., in a commit message or annotation) so future readers can quickly understand what functional change corresponds to this version increment.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The datasource regex is becoming long and error‑prone to maintain; consider simplifying it (e.g., using a shared prefix/suffix pattern or a character class for cluster identifiers) so new clusters can be added with less duplication.
- When updating the dashboard `version`, it can help to note the reason for the bump (e.g., in a commit message or annotation) so future readers can quickly understand what functional change corresponds to this version increment.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Rajagopalan-Ranganathan
Copy link
Contributor

/lgtm

@akoserwal akoserwal merged commit c0ea1c2 into project-kessel:main Mar 9, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants