RHCLOUD-43676 add hccp01 cluster to dashboard#840
Merged
akoserwal merged 1 commit intoproject-kessel:mainfrom Mar 9, 2026
Merged
RHCLOUD-43676 add hccp01 cluster to dashboard#840akoserwal merged 1 commit intoproject-kessel:mainfrom
akoserwal merged 1 commit intoproject-kessel:mainfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Kessel - Relations API Grafana dashboard to include the new hccp01ue1 Prometheus cluster in the datasource selection and bumps the dashboard version metadata accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The datasource regex is becoming long and error‑prone to maintain; consider simplifying it (e.g., using a shared prefix/suffix pattern or a character class for cluster identifiers) so new clusters can be added with less duplication.
- When updating the dashboard
version, it can help to note the reason for the bump (e.g., in a commit message or annotation) so future readers can quickly understand what functional change corresponds to this version increment.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The datasource regex is becoming long and error‑prone to maintain; consider simplifying it (e.g., using a shared prefix/suffix pattern or a character class for cluster identifiers) so new clusters can be added with less duplication.
- When updating the dashboard `version`, it can help to note the reason for the bump (e.g., in a commit message or annotation) so future readers can quickly understand what functional change corresponds to this version increment.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Rajagopalan-Ranganathan
approved these changes
Mar 9, 2026
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Template:
Describe your changes
https://issues.redhat.com/browse/RHCLOUD-43676
Ticket reference (if applicable)
Fixes #
Checklist
Are the agreed upon acceptance criteria fulfilled?
Was the 4-eye-principle applied? (async PR review, pairing, ensembling)
Do your changes have passing automated tests and sufficient observability?
Are the work steps you introduced repeatable by others, either through automation or documentation?
The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)
Are the agreed upon coding/architectural practices applied?
Are security needs fullfilled? (e.g. no internal URL)
Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)
For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?
Summary by Sourcery
Enhancements: