Skip to content

Try make changelog job only run if PR is ready - #274

Draft
0xddom wants to merge 2 commits into
mainfrom
dani/changelog-ci-task-tweak
Draft

Try make changelog job only run if PR is ready#274
0xddom wants to merge 2 commits into
mainfrom
dani/changelog-ci-task-tweak

Conversation

@0xddom

@0xddom 0xddom commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Having the changelog job constantly failing while something is not ready can get pretty annoying. This changes try to make it run only when the PR is ready fo review.

It should:

  • Not run on commits while PR is a draft
  • Run changelog job when the PR is converted even if there aren't any new commits

@0xddom
0xddom requested a review from a team January 20, 2026 13:51
@0xddom
0xddom marked this pull request as ready for review January 20, 2026 13:53
@0xddom
0xddom marked this pull request as draft January 20, 2026 13:54
@0xddom
0xddom marked this pull request as ready for review January 20, 2026 16:50
@0xddom
0xddom marked this pull request as draft January 20, 2026 16:50
@0xddom

0xddom commented Jan 20, 2026

Copy link
Copy Markdown
Contributor Author

Still not ready. I move the PR to draft to ready to review and doesn't trigger the job

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

  2 files  ±0    2 suites  ±0   10m 16s ⏱️ ±0s
371 tests ±0  367 ✅ ±0  4 💤 ±0  0 ❌ ±0 
742 runs  ±0  734 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 9358887. ± Comparison against base commit 5a013d1.

@iangneal

Copy link
Copy Markdown
Contributor

@codex complete the task for this PR.

@chatgpt-codex-connector

Copy link
Copy Markdown

Summary

  • Preserved the existing path-filtered changelog workflow for opened, reopened, synchronized, and review-requested events, while continuing to skip validation when the PR remains a draft. .github/workflows/changelog-validator.ymlL4-L23
  • Added a dedicated, unfiltered ready_for_review workflow so changelog validation runs whenever a draft PR becomes ready—even when the PR only changes documentation or workflow files. .github/workflows/changelog-validator-ready.ymlL1-L16
  • Committed the changes in commit de75426 (Trigger changelog validation when PR becomes ready) and created the follow-up PR titled “Fix changelog validation on ready-for-review transitions.”

Testing

  • ruby -e "require 'yaml'; ARGV.each { |f| YAML.parse_file(f); puts \"parsed #{f}\" }" .github/workflows/changelog-validator.yml .github/workflows/changelog-validator-ready.yml
  • git diff --check
  • git status --short --branch (working tree clean after commit)
  • ⚠️ actionlint .github/workflows/changelog-validator.yml .github/workflows/changelog-validator-ready.yml (not run because actionlint is not installed in the environment)

View task →

@iangneal

Copy link
Copy Markdown
Contributor

@0xddom why is this still not ready? It seems like it should work as-is. The changelog validator just won't run for this particular PR .github/** is excluded from the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants