Verify felt template argument fields - #634
Conversation
5befcbb to
7996098
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f572eed8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2ea30f9 to
bd2187e
Compare
bd2187e to
6737f26
Compare
975fab3 to
dd7e56f
Compare
dd7e56f to
10d101b
Compare
c5c3c31 to
76c9aae
Compare
76c9aae to
770f22d
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4a20e5941
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Converting to draft until #633 is completed |
3 participants
Split from #604.
Verify felt template constants against required fields for parameterized structs, free-function calls, and contract includes. Fieldless constants adopt the required felt type; an explicit field must match exactly.
Covers accepted fieldless and matching constants, rejected mismatches at all three entry points, materialization unit coverage, and syntax documentation.
Validation:
CI