handle heterogeneous arrays in flattening pass by tim-hoffman · Pull Request #660 · project-llzk/llzk-lib

tim-hoffman · 2026-07-30T19:52:19Z

Summary

Update flattening pass to create a series of flattened structs for an array of heterogeneous structs.

Related issues

Fixes #296

tim-hoffman · 2026-07-30T19:55:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74c9383a7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-07-30T20:17:53Z

Test Results

2 files ± 0 2 suites ±0 6m 40s ⏱️ +53s
423 tests +28 419 ✅ +28 4 💤 ±0 0 ❌ ±0
846 runs +56 838 ✅ +56 8 💤 ±0 0 ❌ ±0

Results for commit 755ef86. ± Comparison against base commit 9f3b2a6.

♻️ This comment has been updated with latest results.

tim-hoffman · 2026-07-31T01:15:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf4ba11ae4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-07-31T02:14:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44d8aafd08

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-08-11T21:07:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d350c0c4d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-08-12T14:46:43Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5483b9f86e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-08-12T17:12:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0414c2294

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-08-12T19:36:20Z

@codex review

chatgpt-codex-connector

💡 Codex Review

llzk-lib/lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Lines 1964 to 1969 in bf67a58

    
           Block &newTemplateBody = newTemplate.getBodyRegion().front(); 
        
           for (Attribute name : layout.remainingNames) { 
        
             FlatSymbolRefAttr nameSym = llvm::cast<FlatSymbolRefAttr>(name); 
        
             Operation *paramOp = symTables.getSymbolTable(parentTemplate).lookup(nameSym.getAttr()); 
        
             assert(paramOp && "symbol must exist"); 
        
             newTemplateBody.push_back(paramOp->clone());

Preserve sibling callees in partial templates

When the partially instantiated function contains a flat call to a sibling function in the original template, the cloned template contains only the remaining parameters, copied expressions, and newFunc; it does not contain that sibling. The flat callee consequently resolves relative to the new template and becomes an unknown symbol, so applyBodyConversions() rejects an otherwise valid partial instantiation. Copy referenced sibling functions recursively or rewrite such callees to a path that still resolves in the original template.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

it already has a failure though

tim-hoffman · 2026-08-12T22:36:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 755ef86fa9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-12T22:42:54Z

+  for (OpOperand &use : result.getUses()) {
+    Operation *user = use.getOwner();


Validate unifiable-cast consumers before replacing reads

When a generic array read feeds poly.unifiable_cast to an independently concrete type, this dispatch falls through without checking the cast. For example, a read replaced with Cell<0> may validly have been cast from generic Cell<#id> to Cell<1> before scalarization; replacing its input makes the cast operands non-unifiable, and UnifiableCastOp::verify() then rejects the transformed IR. Fresh evidence after the other consumer-specific fixes is that the reviewed helper still has no UnifiableCastOp branch; reject the replacement when the concrete input cannot unify with the cast result.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-12T22:42:54Z

+  for (OpOperand &use : result.getUses()) {
+    Operation *user = use.getOwner();


Check array writes before refining member reads

When a generic MemberReadOp feeds an array.write whose destination has an independently concrete element type, this consumer is ignored. A read that initially unifies with both Cell<0> from the refined member and a destination requiring Cell<1> is retagged to Cell<0>, leaving the unchanged array write invalid. Fresh evidence beyond the existing call/initializer guards is that this loop still has no WriteArrayOp case; decline the member refinement unless the destination element type accepts refinedType.

Useful? React with 👍 / 👎.

tim-hoffman added 2 commits July 30, 2026 14:46

add constant folding for applymap op

68c97a5

changelog

5291572

chatgpt-codex-connector Bot reviewed Jul 30, 2026

View reviewed changes

tim-hoffman added 2 commits July 30, 2026 15:03

handle heterogeneous arrays in flattening pass

f932193

changelog

e4dfcc5

tim-hoffman force-pushed the th/296 branch from 74c9383 to e4dfcc5 Compare July 30, 2026 20:03

tim-hoffman added 3 commits July 30, 2026 15:24

fix: Preserve table offsets on split member reads

1d17f85

fix: Preserve source attributes on replacement member writes

19e1af8

fix: Refresh dependent candidates after replacing array reads

21226c2

Base automatically changed from th/applymap_folding to main July 31, 2026 00:40

tim-hoffman added 5 commits July 30, 2026 19:40

handle heterogeneous arrays in flattening pass

cb1c312

changelog

f23fc2a

fix: Preserve table offsets on split member reads

a299cab

fix: Preserve source attributes on replacement member writes

3324cdc

fix: Refresh dependent candidates after replacing array reads

ff91cdd

tim-hoffman force-pushed the th/296 branch from 21226c2 to ff91cdd Compare July 31, 2026 00:40

tim-hoffman added 3 commits July 30, 2026 20:14

Merge branch 'th/296' of github.com:project-llzk/llzk-lib into th/296

bd54be7

fix: Reject members with writers that cannot be split

2dba2bf

handle cases of unwritten values

bf4ba11

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

tim-hoffman added 4 commits July 30, 2026 20:49

fix: Seed scalar values from inline array initializers

54cc999

fix: Keep scalar member reads at the original read point

70fab49

fix: Allow expandable arrays to populate multiple split members

50b341e

fix: Preserve metadata on replacement member reads

44d8aaf

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp Outdated

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

fix: Copy discardable attributes to split member definitions

935e0a9

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp Outdated

tim-hoffman and others added 5 commits August 11, 2026 16:39

group flattening pass tests into fewer files

b62d636

fix: Validate every typed consumer before replacing array reads

7dc72b9

expand on regression test comment

63341ac

Merge branch 'main' into th/296

eca337f

fix: Reject candidate writes with different index sets

5483b9f

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

tim-hoffman added 5 commits August 12, 2026 10:35

fix: Validate array initializers before replacing reads

2f72015

fix: Keep reads with conflicting provenance separate

14b50be

fix: Preflight split-read consumers before mutating candidates

b046172

fix: Preserve external observations when refining direct writes

a341d08

fix: Guard array initializers before refining member reads

eb70755

project-llzk deleted a comment from chatgpt-codex-connector Bot Aug 12, 2026

add test for: Materialize shared unifiable casts before split writes

c0414c2

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp Outdated

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp Outdated

tim-hoffman added 5 commits August 12, 2026 12:39

fix: Preflight local read consumers before rewriting candidates

dfe3d1a

clang-tidy

b42cb2b

fix: Validate every member target before retagging casts

4a28b9b

fix: Preserve per-element write attributes on scalar writes

3d6c216

combine duplicate code

bf67a58

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

fix: Preserve sibling callees in partial templates

29df055

tim-hoffman force-pushed the th/296 branch from 83f3c0d to 29df055 Compare August 12, 2026 21:54

add test: Validate return consumers before refining member reads

755ef86

it already has a failure though

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

	Block &newTemplateBody = newTemplate.getBodyRegion().front();
	for (Attribute name : layout.remainingNames) {
	FlatSymbolRefAttr nameSym = llvm::cast<FlatSymbolRefAttr>(name);
	Operation *paramOp = symTables.getSymbolTable(parentTemplate).lookup(nameSym.getAttr());
	assert(paramOp && "symbol must exist");
	newTemplateBody.push_back(paramOp->clone());

		for (OpOperand &use : result.getUses()) {
		Operation *user = use.getOwner();

Uh oh!

Conversation

tim-hoffman commented Jul 30, 2026

Summary

Related issues

Uh oh!

tim-hoffman commented Jul 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

tim-hoffman commented Jul 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Jul 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Aug 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

tim-hoffman commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

github-actions Bot commented Jul 30, 2026 •

edited

Loading