Preserve writes observed by dynamic array reads - #675
Draft
1sgtpepper wants to merge 5 commits into
Draft
Conversation
1sgtpepper
force-pushed
the
fix/dynamic-array-read-write-observation
branch
7 times, most recently
from
August 12, 2026 02:38
204bf1a to
44c33ca
Compare
1sgtpepper
force-pushed
the
fix/dynamic-array-read-write-observation
branch
from
August 12, 2026 02:56
44c33ca to
ff97297
Compare
1sgtpepper
marked this pull request as ready for review
August 12, 2026 12:25
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff97297fd1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1sgtpepper
marked this pull request as draft
August 13, 2026 02:01
Contributor
Author
|
Fixed by dropping null common subtrees at the region-state intersection; the zero-index replacement regression now has complete FileCheck output. Hosted CI is green, and the exact-head replay passed: https://github.com/1sgtpepper/llzk-lib/actions/runs/31666906248 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #673 by preserving writes that a live dynamic-index array read may observe, while keeping tree-shaped write candidates local to their region. Region joins now conservatively drop value facts with no common subtree instead of retaining a null tree.
Related issues
Fixes #673.
Changes
Testing
Hosted CI is green on the checks. The exact-head FileCheck replay passed; the transformed fixtures include complete generated FileCheck output, including the zero-index replacement regression.
Submission checklist
approved; otherwise, this does not apply.AI assistance
Tools used: Codex
How the tools contributed: Implementation and code review.
How I verified the contribution: Final changes reviewed.