Preserve generated check segments - #685
Merged
tim-hoffman merged 5 commits intoAug 13, 2026
Merged
Conversation
|
This pull request is not linked to an issue. Please link the relevant issue using the Development section in the sidebar, or add a closing reference such as: |
7 tasks
1sgtpepper
marked this pull request as ready for review
August 13, 2026 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep generated FileCheck attribute-definition checks in the source segment that produced them, so split-input output preserves source order. This focused prerequisite PR partially addresses the test-generator work needed by #484; it does not change fusion behavior.
Related work
Partially addresses #484, following the maintainer-requested split.
Changes
--sourceand verifies both definitions remain with their producing segment.--sourceis not used.Testing
All required hosted CI checks pass for head
ed20057f95b0dc43c91c7f1648863f3bd3ba40fbon the checks. The new regression exercises the generator and FileCheck together; the focused generator-order harness and Python compilation also pass.Submission checklist
approved; otherwise, this does not apply.AI assistance
Tools used: Codex
How the tools contributed: Implementation and code review.
How I verified the contribution: Final changes reviewed.