Skip to content

Preserve generated check segments - #685

Merged
tim-hoffman merged 5 commits into
project-llzk:mainfrom
1sgtpepper:chore/generate-test-checks-source-order
Aug 13, 2026
Merged

Preserve generated check segments#685
tim-hoffman merged 5 commits into
project-llzk:mainfrom
1sgtpepper:chore/generate-test-checks-source-order

Conversation

@1sgtpepper

@1sgtpepper 1sgtpepper commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Keep generated FileCheck attribute-definition checks in the source segment that produced them, so split-input output preserves source order. This focused prerequisite PR partially addresses the test-generator work needed by #484; it does not change fusion behavior.

Related work

Partially addresses #484, following the maintainer-requested split.

Changes

  • Append each generated attribute-definition check to the current output segment.
  • Add a two-segment regression that runs the generator with --source and verifies both definitions remain with their producing segment.
  • Document the segment-order contract in the generator usage text and changelog.
  • Keep the single-segment path unchanged when --source is not used.

Testing

All required hosted CI checks pass for head ed20057f95b0dc43c91c7f1648863f3bd3ba40fb on the checks. The new regression exercises the generator and FileCheck together; the focused generator-order harness and Python compilation also pass.

Submission checklist

  • If I am an external contributor, this PR has a linked issue marked approved; otherwise, this does not apply.
  • I added or updated tests for all relevant behavior, or explained above why tests are not needed.
  • I updated the relevant TableGen or other documentation, or explained above why documentation is not needed.
  • I added a changelog entry describing user-visible changes.
  • I enabled Allow edits from maintainers.

AI assistance

  • No AI tools contributed to this PR.
  • AI tools contributed to this PR.

Tools used: Codex

How the tools contributed: Implementation and code review.

How I verified the contribution: Final changes reviewed.

@project-llzk-issue-triage

Copy link
Copy Markdown

This pull request is not linked to an issue.

Please link the relevant issue using the Development section in the sidebar, or add a closing reference such as:

Closes #123

@1sgtpepper
1sgtpepper marked this pull request as ready for review August 13, 2026 11:44
@1sgtpepper
1sgtpepper requested a review from a team as a code owner August 13, 2026 11:44

@tim-hoffman tim-hoffman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tim-hoffman
tim-hoffman merged commit c70f077 into project-llzk:main Aug 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants