Phase 0: reconcile docs to live code + remove dead code#6
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughDocumentation now reflects the Field Manual design, PostgreSQL-only setup, free product positioning, and current testing guidance. A phased remediation plan was added, the Ethereal Glass plan was marked superseded, and the obsolete browser LLM integration was removed. ChangesProject documentation alignment
Phased remediation plan
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
- Rewrite AGENTS.md/README design system to the live 'Field Manual' light theme (the 'Ethereal Glass' dark design was reverted) - Correct tech stack: PostgreSQL-only (no SQLite), Bun/CI-npm, pdfkit note - Fix REMEDIATION_PLAN false claims (download route is 53 lines, not 879; SQLite) - Mark REDESIGN-PLAN.md as superseded - Delete truly-dead code (zero references): browser-llm-integration.ts (338-line unused fake rule-based AI) - NOTE: UpgradeModal/SubscriptionBanner/pricing.ts are compile-time shims still imported by components; their removal is deferred to Phase 3/4 (entitlement + component refactor), not Phase 0. - Add FIX-PLAN.md tracking the full SOLID/UI remediation roadmap
projectamazonph
force-pushed
the
fix/phase0-docs-dead-code
branch
from
July 18, 2026 17:18
8b29141 to
15e4e38
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@FIX-PLAN.md`:
- Around line 19-24: Insert a blank line between the explanatory paragraph and
the Phase 0 table in FIX-PLAN.md, immediately before the table header, so the
Markdown table satisfies MD058.
In `@README.md`:
- Around line 105-108: Remove the deleted pricing.ts entry from the project
structure in README.md. In FIX-PLAN.md, mark pricing.ts as deleted and add it to
the Phase 0 verification command; update both documented locations consistently.
- Line 153: Reconcile the README test inventory and the Total row: verify the
current API test files, including subscription.test.ts, then update either the
documented count or the listed inventory so both consistently reflect the actual
total of 218 or 187 tests.
- Around line 168-175: Update the README Documentation section’s redesign-plan
entry to mark REDESIGN-PLAN.md as superseded and historical rather than
presenting it as the active UI/UX redesign plan; preserve the surrounding
documentation links and wording.
In `@REMEDIATION_PLAN.md`:
- Line 115: Update the README correction note in the remediation plan to remove
the future-dated July 19, 2026 reference or replace it with the actual update
date, preserving the existing description of the Bun/npm, SQLite/PostgreSQL, and
next.config.ts corrections.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e92859f2-5cbf-44cf-b0e7-3e0ee6e1d13a
📒 Files selected for processing (9)
AGENTS.mdFIX-PLAN.mdREADME.mdREDESIGN-PLAN.mdREMEDIATION_PLAN.mdsrc/components/interview-lab/SubscriptionBanner.tsxsrc/components/interview-lab/UpgradeModal.tsxsrc/lib/browser-llm-integration.tssrc/lib/pricing.ts
💤 Files with no reviewable changes (4)
- src/components/interview-lab/SubscriptionBanner.tsx
- src/components/interview-lab/UpgradeModal.tsx
- src/lib/browser-llm-integration.ts
- src/lib/pricing.ts
Comment on lines
+19
to
+24
| | File | Reason | | ||
| |------|--------| | ||
| | `src/lib/browser-llm-integration.ts` (338 lines) | Not imported anywhere; fake rule-based AI | | ||
| | `src/components/interview-lab/UpgradeModal.tsx` | Stub, no-op | | ||
| | `src/components/interview-lab/SubscriptionBanner.tsx` | Stub, no-op | | ||
| | `src/lib/pricing.ts` (tier config) — *optional* | Only powers stubs; keep if PricingPage ever real | |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add the required blank line before the table.
markdownlint-cli2 reports MD058 at Line 19. Insert a blank line between the explanatory paragraph and the Phase 0 table.
🧰 Tools
🪛 markdownlint-cli2 (0.23.0)
[warning] 19-19: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@FIX-PLAN.md` around lines 19 - 24, Insert a blank line between the
explanatory paragraph and the Phase 0 table in FIX-PLAN.md, immediately before
the table header, so the Markdown table satisfies MD058.
Source: Linters/SAST tools
Comment on lines
105
to
+108
| ├── lib/ | ||
| │ ├── auth-helpers.ts # Server-side JWT + header auth | ||
| │ ├── pricing.ts # Tier configs (Free/Starter/Pro) and limits | ||
| │ ├── subscription-guard.ts # Feature access checks per tier | ||
| │ ├── pricing.ts # Tier configs (currently unused — product is free) | ||
| │ ├── subscription-guard.ts # Feature access checks (returns allowed: true) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Keep all cleanup documentation consistent with the deleted pricing module.
The PR removes src/lib/pricing.ts, but both documentation surfaces still describe it as present or optionally retained.
README.md#L105-L108: remove the deletedpricing.tsentry from the project structure.FIX-PLAN.md#L18-L26: markpricing.tsas deleted and include it in the Phase 0 verification command.
📍 Affects 2 files
README.md#L105-L108(this comment)FIX-PLAN.md#L18-L26
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` around lines 105 - 108, Remove the deleted pricing.ts entry from
the project structure in README.md. In FIX-PLAN.md, mark pricing.ts as deleted
and add it to the Phase 0 verification command; update both documented locations
consistently.
|
|
||
| ### P2.6 — Operational documentation | ||
| **Problem:** README documents Bun runtime but CI uses npm; describes SQLite but schema is PostgreSQL; no standalone output config. | ||
| **Problem:** README previously documented Bun runtime but CI uses npm; described SQLite but schema is PostgreSQL. (README corrected 2026-07-19; standalone output already in `next.config.ts`.) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the future-dated README correction.
This document says the README was corrected on July 19, 2026, but the current date is July 18, 2026. Use the actual update date or omit the date to keep the audit chronology accurate.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@REMEDIATION_PLAN.md` at line 115, Update the README correction note in the
remediation plan to remove the future-dated July 19, 2026 reference or replace
it with the actual update date, preserving the existing description of the
Bun/npm, SQLite/PostgreSQL, and next.config.ts corrections.
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@FIX-PLAN.md`:
- Line 3: Update the audit date in FIX-PLAN.md from the future date to the
actual current audit date, July 18, 2026, while preserving the surrounding plan
text.
- Line 14: Resolve the PDF implementation contradiction across the README Tech
Stack “Export” row and the Phase 2 plan at lines 66-68 by selecting one final
approach. If Phase 2 removes the manual PDF builder, document only pdfkit
consistently; otherwise update both sections to consistently retain the manual
builder alongside pdfkit.
- Line 113: Update FIX-PLAN.md to document LOG_QUERIES as a new environment
variable, including where its configuration should be documented, its default
behavior, and the production-safe value for LOG_QUERIES=1. Ensure the plan
explicitly states that query logging is disabled by default and remains off in
production.
- Around line 21-26: Resolve the Phase 0 cleanup scope for src/lib/pricing.ts
instead of marking it optional. If it is part of the deletion, update the file
list and rationale to state that clearly and include pricing.ts in the grep
verification; otherwise revise the stated objective and all related cleanup
documentation to exclude it consistently.
- Line 106: Update the rate-limiter replacement entry in FIX-PLAN.md to add a
concise rationale for choosing `@upstash/ratelimit`, explicitly contrasting its
shared Vercel-compatible Redis state with a custom limiter or existing
dependency. Keep the change limited to documenting this dependency choice.
- Line 58: Clarify the plan’s intended malformed-response contract for the AI
coach endpoint: either update src/app/api/ai/coach/route.ts, its callers, and
API documentation so invalid model JSON returns 500 instead of synthetic
feedback, or revise the planned handlers.test.ts expectation to preserve the
current 200 response behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: aab133e5-e84c-4227-b197-a8bedc1972b3
📒 Files selected for processing (6)
AGENTS.mdFIX-PLAN.mdREADME.mdREDESIGN-PLAN.mdREMEDIATION_PLAN.mdsrc/lib/browser-llm-integration.ts
💤 Files with no reviewable changes (1)
- src/lib/browser-llm-integration.ts
🚧 Files skipped from review as they are similar to previous changes (4)
- REDESIGN-PLAN.md
- AGENTS.md
- REMEDIATION_PLAN.md
- README.md
| @@ -0,0 +1,133 @@ | |||
| # Interview Lab — Thorough Fix Plan | |||
|
|
|||
| > Audited 2026-07-19. A sequenced, merge-ready plan. Each phase: **goal → files → changes → verification**. | |||
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use a non-future audit date.
Line [3] says Audited 2026-07-19, but the current date is July 18, 2026. Use the actual audit date to avoid claiming verification occurred tomorrow.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@FIX-PLAN.md` at line 3, Update the audit date in FIX-PLAN.md from the future
date to the actual current audit date, July 18, 2026, while preserving the
surrounding plan text.
| ### 0.1 Documentation truth-up | ||
| **Files:** `AGENTS.md`, `README.md`, `REDESIGN-PLAN.md`, `REMEDIATION_PLAN.md`, `docs/architecture.md` | ||
| - Rewrite AGENTS.md "Design System" section: replace *"Ethereal Glass / OLED black / sky `#007EFF`"* with the live **"Field Manual" light theme** (`#FAFAF7` bg, `#FF6B35` accent, `FieldCard`/`FieldButton`). | ||
| - README Tech Stack: change `UI` row to "Tailwind v4 + Field Manual design system"; fix `Export` row ("pdfkit" → "pdfkit + manual PDF builder" or remove pdfkit after Phase 3). |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Resolve the PDF implementation contradiction.
Line [14] permits documenting “pdfkit + manual PDF builder,” while Lines [66-68] plan to replace the hand-rolled builder with pdfkit. State one final implementation in the README plan—preferably pdfkit if Phase 2 removes the manual builder.
Also applies to: 66-68
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@FIX-PLAN.md` at line 14, Resolve the PDF implementation contradiction across
the README Tech Stack “Export” row and the Phase 2 plan at lines 66-68 by
selecting one final approach. If Phase 2 removes the manual PDF builder,
document only pdfkit consistently; otherwise update both sections to
consistently retain the manual builder alongside pdfkit.
Comment on lines
+21
to
+26
| | `src/lib/browser-llm-integration.ts` (338 lines) | Not imported anywhere; fake rule-based AI | | ||
| | `src/components/interview-lab/UpgradeModal.tsx` | Stub, no-op | | ||
| | `src/components/interview-lab/SubscriptionBanner.tsx` | Stub, no-op | | ||
| | `src/lib/pricing.ts` (tier config) — *optional* | Only powers stubs; keep if PricingPage ever real | | ||
|
|
||
| **Verify:** `grep -r "browser-llm-integration\|UpgradeModal\|SubscriptionBanner" src` → no results; `bun run build` passes. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Align the pricing cleanup with the stated Phase 0 objective.
The PR objective says four files are removed, including pricing.ts, but Line [24] makes that deletion optional and Line [26] does not verify it. Decide whether pricing.ts is deleted, then update the file list, rationale, and grep command consistently.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@FIX-PLAN.md` around lines 21 - 26, Resolve the Phase 0 cleanup scope for
src/lib/pricing.ts instead of marking it optional. If it is part of the
deletion, update the file list and rationale to state that clearly and include
pricing.ts in the grep verification; otherwise revise the stated objective and
all related cleanup documentation to exclude it consistently.
| ### 1.4 Add zod schemas | ||
| - `src/lib/ai/schemas.ts`: `CoachFeedbackSchema`, `ResumeReviewSchema`, `CoverLetterSchema`, `AssessmentScoreSchema` (replaces runtime `as` casts). | ||
|
|
||
| **Verify:** `__tests__/ai/client.test.ts` (mock `z-ai-web-dev-sdk`), `handlers.test.ts` (valid + malformed JSON → 500), `bun run test`. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== Relevant files ==\n'
git ls-files 'FIX-PLAN.md' 'src/app/api/ai/coach/route.ts' '__tests__/ai/client.test.ts' 'handlers.test.ts'
printf '\n== FIX-PLAN.md excerpt ==\n'
nl -ba FIX-PLAN.md | sed -n '45,70p'
printf '\n== route.ts excerpt ==\n'
nl -ba src/app/api/ai/coach/route.ts | sed -n '1,220p'
printf '\n== Search for JSON parsing / fallback / HTTP 500 ==\n'
rg -n "JSON.parse|fallback feedback|return NextResponse\.json|status:\s*500|malformed|coach" src __tests__ FIX-PLAN.mdRepository: projectamazonph/Interview-lab
Length of output: 298
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== FIX-PLAN.md excerpt ==\n'
sed -n '45,70p' FIX-PLAN.md | cat -n
printf '\n== route.ts excerpt ==\n'
sed -n '1,220p' src/app/api/ai/coach/route.ts | cat -n
printf '\n== Search for related tests and behavior ==\n'
rg -n "JSON.parse|fallback feedback|return NextResponse\.json|status:\s*500|malformed|coach" src __tests__ FIX-PLAN.md || true
printf '\n== Find test files ==\n'
fd -a 'client.test.ts|handlers.test.ts' . || trueRepository: projectamazonph/Interview-lab
Length of output: 42809
Preserve the AI coach malformed-response contract.
src/app/api/ai/coach/route.ts still falls back to synthetic feedback and returns 200 on invalid model JSON. If this plan is meant to switch that endpoint to 500, update the callers and API docs together; otherwise keep the test aligned with the current behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@FIX-PLAN.md` at line 58, Clarify the plan’s intended malformed-response
contract for the AI coach endpoint: either update src/app/api/ai/coach/route.ts,
its callers, and API documentation so invalid model JSON returns 500 instead of
synthetic feedback, or revise the planned handlers.test.ts expectation to
preserve the current 200 response behavior.
|
|
||
| ## Phase 5 — Infra & Correctness | ||
| ### 5.1 Rate limiter (`middleware.ts`) | ||
| - Replace in-memory `Map` with **Upstash Redis** (`@upstash/ratelimit`) so it works across Vercel serverless. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
sed -n '90,120p' FIX-PLAN.mdRepository: projectamazonph/Interview-lab
Length of output: 1324
🏁 Script executed:
rg -n "Upstash|ratelimit|dependency decision|50-line|custom solution|existing dependency|Vercel serverless|rate limiter" FIX-PLAN.md README.md docs .github . 2>/dev/nullRepository: projectamazonph/Interview-lab
Length of output: 781
Document the rate-limiter dependency choice. Add a short rationale for choosing @upstash/ratelimit over a small custom limiter or an existing dependency.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@FIX-PLAN.md` at line 106, Update the rate-limiter replacement entry in
FIX-PLAN.md to add a concise rationale for choosing `@upstash/ratelimit`,
explicitly contrasting its shared Vercel-compatible Redis state with a custom
limiter or existing dependency. Keep the change limited to documenting this
dependency choice.
Source: Coding guidelines
| - `JetBrains Mono`/`Inter` declared but unused → align to Space Grotesk + Plus Jakarta Sans (per spec) or update spec. | ||
|
|
||
| ### 5.3 `db.ts` | ||
| - Gate `log: ['query']` behind explicit `LOG_QUERIES=1` env (confirm off in prod). |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Document LOG_QUERIES as a new environment variable.
Specify the documentation location, expected default, and production-safe value for LOG_QUERIES=1; every new environment variable must be documented.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@FIX-PLAN.md` at line 113, Update FIX-PLAN.md to document LOG_QUERIES as a new
environment variable, including where its configuration should be documented,
its default behavior, and the production-safe value for LOG_QUERIES=1. Ensure
the plan explicitly states that query logging is disabled by default and remains
off in production.
Source: Coding guidelines
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves spec drift between documentation and the actual codebase (part of the audit / FIX-PLAN.md roadmap).
Doc truth-up
Dead code removed (zero references, confirmed via grep)
src/lib/browser-llm-integration.ts (338 lines, unused fake rule-based AI)
src/components/interview-lab/UpgradeModal.tsx (stub)
src/components/interview-lab/SubscriptionBanner.tsx (stub)
src/lib/pricing.ts (tier config powering only stubs)
Adds FIX-PLAN.md tracking the full SOLID/UI remediation roadmap (Phases 1-5).
Test plan
Note: build could not be verified in the local sandbox (Prisma v7 vs schema v6
url = env()mismatch plus node_modules not installed). This is a pre-existing environment issue, not introduced by these changes.Generated with opencode
Summary by CodeRabbit
Documentation
Refactor