Skip to content

⚡ Bolt: Optimize Listing Audit scoring engine nested lookups #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
projectamazonph merged 1 commit into from
Jul 20, 2026
Merged

⚡ Bolt: Optimize Listing Audit scoring engine nested lookups #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/engine/listing-audit/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,16 @@ export function gradeListingAudit(
): ListingAuditGrade {
const ref = scenario.referenceFindings;

// Bolt optimization: Map reference findings by field to replace O(N*M) nested lookups with O(1) lookups
const refMap = new Map<string, ListingAuditFinding>(
ref.map((rf) => [rf.field, rf])
);

const criteria: CriterionResult[] = [
// Findings identification
findingsIdentified(studentFindings, ref),
findingsAccuracy(studentFindings, ref),
severityCalibration(studentFindings, ref),
findingsAccuracy(studentFindings, refMap),
severityCalibration(studentFindings, refMap),

// Listing revision (optional but weighted higher)
titleQuality(scenario.referenceListing.title, studentRevision?.title),
Expand Down Expand Up @@ -78,14 +83,14 @@ function findingsIdentified(

function findingsAccuracy(
student: ListingAuditFinding[],
ref: ListingAuditFinding[]
refMap: Map<string, ListingAuditFinding>
): CriterionResult {
if (student.length === 0) {
return binaryCriterion('findings_accuracy', false, PASS, 'No findings submitted.');
}
let truePositives = 0;
for (const sf of student) {
const match = ref.find((rf) => rf.field === sf.field);
const match = refMap.get(sf.field);
if (!match) continue;
// Severity at least matches
if (severityAtLeast(sf.severity, match.severity)) truePositives++;
Expand All @@ -102,12 +107,12 @@ function findingsAccuracy(

function severityCalibration(
student: ListingAuditFinding[],
ref: ListingAuditFinding[]
refMap: Map<string, ListingAuditFinding>
): CriterionResult {
let correct = 0;
let total = 0;
for (const sf of student) {
const match = ref.find((rf) => rf.field === sf.field);
const match = refMap.get(sf.field);
if (!match) continue;
total++;
if (sf.severity === match.severity) correct++;
Expand Down