Skip to content

Remove cros_gralloc include directory#103

Open
JeevakaPrabu wants to merge 1 commit intoprojectceladon:masterfrom
JeevakaPrabu:minigbm_include_path_removal
Open

Remove cros_gralloc include directory#103
JeevakaPrabu wants to merge 1 commit intoprojectceladon:masterfrom
JeevakaPrabu:minigbm_include_path_removal

Conversation

@JeevakaPrabu
Copy link
Collaborator

Removing hardcoded cros_gralloc include directory as it is already added in mfx_c2_defs.mk

Tracked-On: OAM-110710

Tracked-On: OAM-110710
Signed-off-by: Jeevaka Prabu Badrappan <jeevaka.badrappan@intel.com>

include_dirs: [
"hardware/intel/external/minigbm-intel/cros_gralloc", // remove then minigbm gets Android.bp
"hardware/intel/external/minigbm/cros_gralloc", // remove then minigbm gets Android.bp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks we don't have this folder hardware/intel/external/minigbm/cros_gralloc in celadon. What we have is hardware/intel/external/minigbm-intel.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci requested review from TianmiChen and dyang23 June 14, 2023 05:53
@sysopenci sysopenci requested review from YuanjunHuang and yyao3 June 14, 2023 05:53
@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci sysopenci added the Stale Stale label for inactive open prs label Sep 6, 2024
@sysopenci
Copy link

one of the dependent pr's program name is not compatable with other dependent prs, for more details please check tracked_on

1 similar comment
@sysopenci
Copy link

one of the dependent pr's program name is not compatable with other dependent prs, for more details please check tracked_on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale Stale label for inactive open prs Valid commit message

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants