Close LG instance when corresponding app crashes #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangwan01
reviewed
Jan 5, 2022
| continue; | ||
| } | ||
| // start msg xchange | ||
| pthread_t thread; |
Contributor
There was a problem hiding this comment.
thread is declared in stack, does the new connection will overwrite the existing threads?
| // 0 is reserved for the main channel | ||
| if (channel->id_ > 0) { | ||
| //Mark the end of this thread | ||
| dispatcher->t_clients_.erase(channel->id_); |
Contributor
There was a problem hiding this comment.
Does the thread join need to be handled here?
| msg = chnl->msg_queue.front(); | ||
| chnl->msg_queue.pop(); | ||
| channel = chnl; | ||
| bMsg = true; |
Contributor
There was a problem hiding this comment.
Does the break need to be added here to avoid possible msg lost if multiple messages arriving?
amritaintel
force-pushed
the
sing_vsock
branch
from
d98baa9 to
d1c4061
Compare
Tracked-On: OAM-100054 Signed-off-by: ahs <amrita.h.s@intel.com>
amritaintel
force-pushed
the
sing_vsock
branch
from
d1c4061 to
b0e036d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked-On: OAM-100054
Signed-off-by: ahs amrita.h.s@intel.com