Skip to content

Composition with vpp#94

Open
HaihongxLi wants to merge 4 commits intoprojectceladon:celadon/u/mr0/masterfrom
HaihongxLi:vpp
Open

Composition with vpp#94
HaihongxLi wants to merge 4 commits intoprojectceladon:celadon/u/mr0/masterfrom
HaihongxLi:vpp

Conversation

@HaihongxLi
Copy link
Contributor

No description provided.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

Signed-off-by: lihaihong <haihongx.li@intel.com>
@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

...as PRIME_2 API allows us to set modifier.

Signed-off-by: Weifeng Liu <weifeng.liu@intel.com>
}

bool VARenderer::AllocateCache(uint32_t layer_capacity) {
surface_in_ = (VASurfaceID*)malloc(sizeof(VASurfaceID) * layer_capacity);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use std::vector to manage these resources as we are writing C++ here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

porting from previous, now we need poc and do some test, next will refine

Signed-off-by: lihaihong <haihongx.li@intel.com>
@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

Signed-off-by: lihaihong <haihongx.li@intel.com>
@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Engineering Build Not Started Engineering Build Not Started Invalid commit message Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants