Skip to content

Conversation

@jeremy-compostella
Copy link

The previous implementation did not update the bootimage pointer when an initbootimage was present, which was leading to improper memcpy in subsequent operations. This commit ensures that when initbootimage is provided, both the boot_hdr and bootimage pointers are updated to reference initbootimage.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review labels Dec 18, 2025
The previous implementation did not update the bootimage pointer when an
initbootimage was present, which was leading to improper memcpy in
subsequent operations. This commit ensures that when initbootimage is
provided, both the boot_hdr and bootimage pointers are updated to reference
initbootimage.

Tracked-On: None

Signed-off-by: Jeremy Compostella <[email protected]>
@sysopenci sysopenci added the Engineering Build Not Started Engineering Build Not Started label Dec 18, 2025
@jeremy-compostella jeremy-compostella force-pushed the jcompost/main branch 2 times, most recently from 850321e to a454ba0 Compare December 18, 2025 02:59
Copy link

@shyjumon-n shyjumon-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremy-compostella
Copy link
Author

What need to be done to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Engineering Build Not Started Engineering Build Not Started Invalid commit message Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants