Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

display fix crash in intel_dp_aux_xfer #117

Open
kanlihu wants to merge 1 commit into
base: celadon/u/mr0/stable
Choose a base branch
from
Open

display fix crash in intel_dp_aux_xfer #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions drivers/gpu/drm/i915/display/intel_dp_aux.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
ch_data[i] = intel_dp->aux_ch_data_reg(intel_dp, i);

if (is_tc_port) {
if (!dig_port) {
ret = -ENXIO;
Copy link

@feijiang1 feijiang1 Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out_fail just "return ret;", why not just return ret here and add additional out_fail?

Copy link

@feijiang1 feijiang1 Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally suggest add some error log here

goto out_fail;
}
intel_tc_port_lock(dig_port);
/*
* Abort transfers on a disconnected port as required by
Expand Down Expand Up @@ -413,6 +417,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
if (is_tc_port)
intel_tc_port_unlock(dig_port);

out_fail:
return ret;
}

Expand Down