-
Notifications
You must be signed in to change notification settings - Fork 18
3 dimension keycode preset #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you!
- Could you also add reference in
Cardinal
docs toSixDOF
and editAxial
to point to onlyCardinal
? - Ccould you also add an integration test in
presets.rs
?
src/preset.rs
Outdated
/// struct Move; | ||
/// ``` | ||
#[derive(Debug, Clone, Copy)] | ||
pub struct SixDOF<I: IntoBindings> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about Spatial
or Tertial
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spatial maybe, but I'm not sure it is better than SixDOF...
I guess it requires a bit less knowledge since you don't need to know DOF = Degrees of Freedom and what that means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alice-i-cecile what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we decide to keep SixDOF
, maybe worth to rename it to SixDof
instead. The convention is to capitalize only the first letter in abbreviations - like Aabb
.
Another option to consider: name these presets <Something>1D
, <Something>2D
and <Something>3D
. Just brainstorming 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya maybe Axis1D
/Axis2D
/Axis3D
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that might make axial vs axis2d confusing... Directional*D?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I Directional*D
is also an option. It's a bit long, but Dir
would be confusing and Bevy already have Dir*
types.
Let's ask Alice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I like "Spatial" best :) SixDoF is really confusing to new gamedevs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aceeri let's go with Spatial
then!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 86.17% 86.30% +0.13%
==========================================
Files 34 34
Lines 1034 1059 +25
==========================================
+ Hits 891 914 +23
- Misses 143 145 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Do you think I should add a new file for the 3 dimensions or modify the existing stuff to just be |
I would modify the action output and constants to |
Or maybe even remove the constants in the test and use the constants from glam itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! But I'd like to get @alice-i-cecile's opinion on the naming. Here are the options we've considered:
SixDof
(renamed fromSixDOF
since in abbreviations only the first letter should be capitalized)Spatial
Directional*D
for all presets
If you have other suggestions, please let us know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this addition (it was in LWIM for a reason!), but we should rename first.
@Aceeri sorry, could you resolve the conflicts? |
Never mind - resolved myself 🙂 |
Adds a preset for 3 dimensional input actions.
Open to better names, SixDOF is just what came to mind for this but it sounds a bit odd.
I did a little builder pattern for wasd/arrow vs up down mappings since people might want to mix and match them. If there are any other up/down presets you think would be common lemme know :)