-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for SequencedCollection, SequencedSet and SequencedMap from JDK 21 #3584
base: master
Are you sure you want to change the base?
Conversation
Thanks for the contribution! I haven't reviewed the whole code yet. I did copy the java 22 gradle fix directly to master, thanks for that solution, because it's not part of this fix. Please remove it from this pull request. |
|
Eclipse IDE 2023-12 test uses JDK 21 unless specified
There are no other suitable classes in Guava now. I think BuilderSingularRedirectToGuava test is sufficient |
c4d9354
to
a876dee
Compare
Awesome contribution! Is the new code covered and ready to be merged after you added |
No, there are some problems with test-eclipse: eclipse-202312, eclipse-202403, eclipse-202406. They execute on JDK 17 and so there are compile errors: new interfaces 'cannot be resolved to a type' |
Adding support for
java.util.SequencedCollection
,java.util.SequencedSet
andjava.util.SequencedMap
from JDK 21 for@Singular
annotation (@Builder
)