Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new JDK23 CommentStyle #3750

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

Rawi01
Copy link
Collaborator

@Rawi01 Rawi01 commented Sep 20, 2024

This PR updates lombok to support the updated CommentStyle enum. I also added JDK 23 as test target.

@reneleonhardt
Copy link

Amazing work, thank you! 🚀

@Harmelodic
Copy link

Tests / test-eclipse (eclipse-I-build) (pull_request) - Failing

...
     [java] Downloading 'org.eclipse.osgi.source_3.22.0.v20240917-0858.jar'... [done]
     [java] Downloading 'org.eclipse.text_3.14.200.v20240915-0736.jar'... [done]
     [java] Downloading 'org.eclipse.text.source_3.14.200.v20240915-0736.jar'... [done]
     [echo] Running TestEclipse on eclipse-I-build on JVM17. Compiler compliance level: latest
    [junit] [ERR] ecj-Accessors.java(lombok.transform.TestWithEcj)
    [junit]   class java.lang.NoSuchFieldError: inlineJsrBytecode
    [junit]     lombok.RunTestsViaEcj.ecjCompilerOptions(RunTestsViaEcj.java:82)
    [junit]     lombok.RunTestsViaEcj.transformCode(RunTestsViaEcj.java:148)
    [junit]     lombok.AbstractRunTests$1.runTest(AbstractRunTests.java:100)
    [junit]     lombok.DirectoryRunner.run(DirectoryRunner.java:173)
    [junit]     org.junit.runners.Suite.runChild(Suite.java:128)

So it fails here: https://github.com/projectlombok/lombok/blob/master/test/core/src/lombok/RunTestsViaEcj.java#L82

because inlineJsrBytecode apparently doesn't exist on the CompilerOptions class for the latest eclipse integration build.

Not sure if that's a known issue to the Lombok devs? or even if it is an issue for this PR? Maybe this could this just be merged?

@reneleonhardt
Copy link

reneleonhardt commented Sep 24, 2024

You don't test against JDK 24, why is a test against an Eclipse integration build not allowed to fail?
For me testing a released version like 2024-09 (two weeks old) would be more important.
https://projects.eclipse.org/releases/2024-09

@Rawi01 in case you didn't notice, there is no explaining comment but I guess docker should be tested against LTS versions and the latest JDK, you didn't replace 22 with 23 there 😉
Unfortunately GitHub doesn't allow me to comment that line, so try it with this link:
https://github.com/projectlombok/lombok/pull/3750/files#diff-861032010d7892d288389586a0f5b825c3f8583a54524f96f5c382a898ce55a5L169

@rzwitserloot rzwitserloot merged commit 6454db6 into projectlombok:master Oct 17, 2024
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants