Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 2.1.2 #1811

Merged
merged 4 commits into from
Sep 23, 2023
Merged

Update version to 2.1.2 #1811

merged 4 commits into from
Sep 23, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented Sep 19, 2023

I included #1757, so it must be merged first.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (3dbabfe) 81.36% compared to head (bef0fa0) 81.34%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
- Coverage   81.36%   81.34%   -0.03%     
==========================================
  Files          15       15              
  Lines         891      879      -12     
  Branches      191      185       -6     
==========================================
- Hits          725      715      -10     
+ Misses        142      141       -1     
+ Partials       24       23       -1     
Files Changed Coverage Δ
mesa/__init__.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpike3
Copy link
Member

tpike3 commented Sep 19, 2023

Can you fix the codespell error on line 41

Copy link
Contributor

@Corvince Corvince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be publishable to PyPi again because of the GitHub dependency of mesa-viz-tornado. We have to package this up first

@Corvince
Copy link
Contributor

But thanks a lot for putting this together @rht

@rht
Copy link
Contributor Author

rht commented Sep 19, 2023

Good catch. I was too hasty, because it has been days without progress.

HISTORY.rst Outdated

* Move viz stuff to mesa-viz-tornado Git repo #1746
* simplify get neighborhood #1760
* remove attrgetter performace optimization #1809
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I copy pasted this from the PR.

@rht
Copy link
Contributor Author

rht commented Sep 20, 2023

This won't be publishable to PyPi again because of the GitHub dependency of mesa-viz-tornado. We have to package this up first

I don't have permission to do so. Please don't delay this any longer.

@Corvince
Copy link
Contributor

What kind of permissions do you mean? There isn't any package on PyPi named mesa-viz-tornado yet, so theoretically anyone can submit such package. I think you also already have some knowledge about packaging a python package, no? So maybe you would be willing to publish? You can also first test on test.pypi.org if everything works.

Otherwise I myself won't have much time until next week. Don't know how it is with @tpike3 or @jackiekazil

@rht
Copy link
Contributor Author

rht commented Sep 20, 2023

There isn't any package on PyPi named mesa-viz-tornado yet, so theoretically anyone can submit such package.

You already know yourself that if it is not published by Mesa's PyPI account, it is bound to draw suspicion.

@tpike3
Copy link
Member

tpike3 commented Sep 20, 2023

Just to recap..

  • we want to release Mesa 2.1.2 today (9/20)
  • we need to package up mesa-viz-tornado Move viz stuff to mesa-viz-tornado Git repo #1746 but it needs to be packaged and released under Mesa so not to be considered suspicious, but the the plan is to do that later (not today)

@Corvince
Copy link
Contributor

There isn't any package on PyPi named mesa-viz-tornado yet, so theoretically anyone can submit such package.

You already know yourself that if it is not published by Mesa's PyPI account, it is bound to draw suspicion.

There is no Mesa PyPi account. Previous versions of mesa have been published by @jackiekazil account. @tpike3 would have the same right. Mesa-geo is either published by myself or @wang-boyu. I wouldn't know who would be suspicious if you published that package @rht . After all you are probably the most active contributor at the moment and member of the core team.

@jackiekazil
Copy link
Member

I can publish right after work today.

@jackiekazil
Copy link
Member

jackiekazil commented Sep 21, 2023

Catching up on where we are. I enthusiastically made my comment too soon ... please let me know if I need to correct anything.

  • This is blocked by needing mesa-viz-tornado release.
    • I created a history ticket - does that need to be done as well -- Add History file for releases  mesa-viz-tornado#29
    • I can do a release of this for speed's sake - we should talk about governance around releases. We discussed this in the past, but we have yet to conclude. (cc @tpike3 for next agenda)
    • readme - we can skip a history for now, but we need a readme; otherwise, people will wonder what is happening. Is there anything else that needs to happen?

Are we imagining the process for now being release mesa-viz-tornado, then Mesa?

@rht
Copy link
Contributor Author

rht commented Sep 21, 2023

I think it's fine to not have the history file for mesa-viz-tornado, since technically it is no longer going to be developed anyway.

@tpike3
Copy link
Member

tpike3 commented Sep 21, 2023

I am also good with no history file for mesa viz at this time. Also are we going to include #1813? (per 1813 count this a bug fix but would it make this release 2.2?) I think we should.

@rht
Copy link
Contributor Author

rht commented Sep 21, 2023

I have updated the changelog to include #1813.

@tpike3
Copy link
Member

tpike3 commented Sep 22, 2023

@rht are you going to remove the requires from github--- https://github.com/projectmesa/mesa/blob/main/setup.py#L11 or do you want me to so we can release to PyPI?

@rht
Copy link
Contributor Author

rht commented Sep 22, 2023

You can do it, to save a roundtrip.

@Corvince
Copy link
Contributor

Corvince commented Sep 22, 2023

@rht are you going to remove the requires from github--- https://github.com/projectmesa/mesa/blob/main/setup.py#L11 or do you want me to so we can release to PyPI?

Wait, but we can't just do that - that would would be a breaking change. Everyone's visualization would be broken.

@rht
Copy link
Contributor Author

rht commented Sep 22, 2023

@tpike3 is going to replace it with a PyPI release version instead of Git version: #1811 (comment)

@Corvince
Copy link
Contributor

Ok I wasn't sure from the wording and there isn't a package yet.

@jackiekazil
Copy link
Member

Quick read me for mesa-viz-tornado?
I would do it, but know less about it than you all. It dosn't have to be fancy, I would cover the following --

TItle
1 Paragraph description
Possible things to include - what is it? Why it exists? who would use it? what is the future state?

@jackiekazil
Copy link
Member

jackiekazil commented Sep 22, 2023

Suggested pattern for release --

  • Update readme in mesa-viz-tornado, release to pypi
  • Adjust setup.py in this repo to point to pypi, not the repo
  • Update history in this repo
  • Release this repo

remove mesa_viz_tornado git install
setup.py Outdated Show resolved Hide resolved
@jackiekazil jackiekazil dismissed Corvince’s stale review September 23, 2023 16:30

This has been resolved... https://pypi.org/project/Mesa-Viz-Tornado/ ... thank you @Corvince for the block.

Copy link
Member

@jackiekazil jackiekazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackiekazil
Copy link
Member

Merging for a release.

@jackiekazil jackiekazil merged commit 734496c into projectmesa:main Sep 23, 2023
@jackiekazil
Copy link
Member

Released - https://pypi.org/project/Mesa/2.1.2/

@rht rht deleted the release branch September 25, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants