-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version to 2.1.2 #1811
Update version to 2.1.2 #1811
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
- Coverage 81.36% 81.34% -0.03%
==========================================
Files 15 15
Lines 891 879 -12
Branches 191 185 -6
==========================================
- Hits 725 715 -10
+ Misses 142 141 -1
+ Partials 24 23 -1
☔ View full report in Codecov by Sentry. |
Can you fix the codespell error on line 41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be publishable to PyPi again because of the GitHub dependency of mesa-viz-tornado. We have to package this up first
But thanks a lot for putting this together @rht |
Good catch. I was too hasty, because it has been days without progress. |
HISTORY.rst
Outdated
|
||
* Move viz stuff to mesa-viz-tornado Git repo #1746 | ||
* simplify get neighborhood #1760 | ||
* remove attrgetter performace optimization #1809 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I copy pasted this from the PR.
I don't have permission to do so. Please don't delay this any longer. |
What kind of permissions do you mean? There isn't any package on PyPi named Otherwise I myself won't have much time until next week. Don't know how it is with @tpike3 or @jackiekazil |
You already know yourself that if it is not published by Mesa's PyPI account, it is bound to draw suspicion. |
Just to recap..
|
There is no Mesa PyPi account. Previous versions of mesa have been published by @jackiekazil account. @tpike3 would have the same right. Mesa-geo is either published by myself or @wang-boyu. I wouldn't know who would be suspicious if you published that package @rht . After all you are probably the most active contributor at the moment and member of the core team. |
I can publish right after work today. |
Catching up on where we are. I enthusiastically made my comment too soon ... please let me know if I need to correct anything.
Are we imagining the process for now being release mesa-viz-tornado, then Mesa?
|
I think it's fine to not have the history file for mesa-viz-tornado, since technically it is no longer going to be developed anyway. |
I am also good with no history file for mesa viz at this time. Also are we going to include #1813? (per 1813 count this a bug fix but would it make this release 2.2?) I think we should. |
I have updated the changelog to include #1813. |
@rht are you going to remove the requires from github--- https://github.com/projectmesa/mesa/blob/main/setup.py#L11 or do you want me to so we can release to PyPI? |
You can do it, to save a roundtrip. |
Wait, but we can't just do that - that would would be a breaking change. Everyone's visualization would be broken. |
@tpike3 is going to replace it with a PyPI release version instead of Git version: #1811 (comment) |
Ok I wasn't sure from the wording and there isn't a package yet. |
Quick read me for mesa-viz-tornado? TItle |
Suggested pattern for release --
|
remove mesa_viz_tornado git install
This has been resolved... https://pypi.org/project/Mesa-Viz-Tornado/ ... thank you @Corvince for the block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging for a release. |
Released - https://pypi.org/project/Mesa/2.1.2/ |
I included #1757, so it must be merged first.