-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Broken Links In Mesa Documentation #2099
Conversation
The index.md is meant to be used to render https://mesa.readthedocs.io/en/stable/, and if you check the links there, they work. |
The links at the top bar do work, but I was refering to links in the main page, here in the highlighted section, for Mesa Introductory Tutorial, and Mesa Visualization Tutorial. I think the files in the tutorial got updated from .html to .ipynb and I guess that's causing this issue. My question is do we replace it with the .ipynb files in the tutorial subfolder? Or will this cause some rendering issue(from .ipynb to html, I don't know if that's possible)? Do let me know, thanks! |
I see, they are indeed broken. But they shouldn't be replaced by a link to GitHub. The end result should be the links go to working pages in Read the Docs. |
@knightwayne are you willing to work further on this, so that the links work in RTD such as @rht suggested? |
Hi, sorry it slipped out of my mind, but sure, I will look into this and submit a fix by tonight! |
PR #2100 should fix this and supercedes the changes made here. |
Superseded by #2100 per @knightwayne |
Fixes #2098
I have also added a link for Mesa Overview on the main page. I am not sure if the replaced links needs to be jupyter notebook links or something else? Do let me know!