Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolaraViz: Remove card title #2241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rht
Copy link
Contributor

@rht rht commented Aug 23, 2024

They are soon going to be part of one umbrella of "measures", instead of distinctly named ones. If a user wants to add a title, they can do it inside Matplotlib/Altair.

They are soon going to be part of one umbrella of "measures", instead of
distinctly named ones. If a user wants to add a title, they can do it
inside Matplotlib/Altair.
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 -0.1% [-0.4%, +0.2%] 🔵 -0.0% [-0.2%, +0.2%]
Schelling large 🔵 +0.2% [-0.4%, +0.7%] 🔵 -1.0% [-1.6%, -0.4%]
WolfSheep small 🔵 -0.5% [-1.7%, +0.7%] 🔵 -1.3% [-1.6%, -1.0%]
WolfSheep large 🔵 -0.4% [-0.7%, -0.0%] 🔵 -0.8% [-1.1%, -0.6%]
BoidFlockers small 🔵 +0.8% [+0.1%, +1.7%] 🔵 -0.2% [-1.1%, +0.7%]
BoidFlockers large 🔵 -0.3% [-1.1%, +0.6%] 🔵 -0.0% [-0.4%, +0.4%]

@tpike3
Copy link
Member

tpike3 commented Aug 26, 2024

@rht Thanks! -- Could you elaborate on "They are soon going to be part of one umbrella of measures". Is this going to be a change to Mesa, Solara or both?

Could you add to the visualization tutorial adding names to the plots? I think this is a small but critical feature for users.

@EwoutH
Copy link
Member

EwoutH commented Aug 30, 2024

How can I help move this forward?

@rht
Copy link
Contributor Author

rht commented Aug 31, 2024

Could you elaborate on "They are soon going to be part of one umbrella of measures"

#2236, and in #2263, where measures and space are merged into "components" (what I earlier called measures).

Could you add to the visualization tutorial adding names to the plots? I think this is a small but critical feature for users.

Currently there is no public API for that, and this PR doesn't add/remove any feature in this area.

How can I help move this forward?

This PR just needs a clarification answer to @tpike3 's questions. Unless there is other missing aspect.

@EwoutH
Copy link
Member

EwoutH commented Sep 20, 2024

@rht @Corvince what's the current state / trajectory of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants