Skip to content

Posts and Comments - ReReddit#232

Open
j-emitch wants to merge 3 commits into
projectshft:masterfrom
j-emitch:master
Open

Posts and Comments - ReReddit#232
j-emitch wants to merge 3 commits into
projectshft:masterfrom
j-emitch:master

Conversation

@j-emitch
Copy link
Copy Markdown

No description provided.

Comment thread index.html
<head>
<title>ReReddit</title>
<link
href="http://maxcdn.bootstrapcdn.com/bootstrap/3.2.0/css/bootstrap.min.css"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bootstrap 3.2.0 is outdated

Comment thread index.html
</div>

<div class="posts"></div>
<form style="margin-top: 30px" onsubmit="event.preventDefault();">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in the js file

Comment thread main.js
};

function createCommentLink () {
var newCommentLink = document.createElement('a');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var newCommentLink = document.createElement('a');
var commentLink = document.createElement('a');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants