Conversation
lmd59
marked this pull request as ready for review
July 9, 2025 15:52
elsaperelli
self-requested a review
July 9, 2025 19:06
Update test id Update contained Fix tests
elsaperelli
requested changes
Jul 11, 2025
| * @returns { string[] } the evaluation service ids for POSTed patients (may be different than sent IDs or undefined if send was unsuccessful) | ||
| */ | ||
| const submitDataToEvaluationService = async (): Promise<(string | undefined)[]> => { | ||
| // collect data and POST to evaluation service (TODO: should be $submit-data when available) |
Contributor
There was a problem hiding this comment.
We don't have to do this right now, but we should consider having some sort of option to do the "poor man's submit-data" or actual $submit-data...
Contributor
Author
There was a problem hiding this comment.
I'll try to do this during the c-thon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A poor man's $submit-data...
Note: This is currently based off of the branch here: #109 and will be rebased once that PR is merged
New Behavior
Adds a submit data button which collates minimum data resources for each patient, adds a data exchange measure report for each (in accordance with https://build.fhir.org/ig/HL7/davinci-deqm/StructureDefinition-datax-measurereport-deqm.html), POSTs that data to the stored evaluation service URL, and enables an evaluate button (currently a stub that opens an empty modal).
The goal is for this to closely reflect a client's use of $submit-data but without actually using the submit data operation.
Code Changes
resourceCreation.tsutil to addcreateDataExchangeMeasureReportfunctionPopulationCalculation.tsxto add two buttons, modal, and functions to do data submissiondataRequirementsLookupByTypeasync selectorNOTE: many TODOs have been left in to give direction for what to change when this becomes a proper $submit-data as well as a TODO for the evaluate implementation and a TODO for a measure report decision that needs to be verified with server systems at the connectathon.
Testing Guidance
npm run check/Patientendpoint to see how many patients there arenpm run dev/Patientendpoint again to see if patient number has increased by number of test cases. (Note: patient number will only increase if test cases aren't already on the server.) If you want to test again with the same test case(s), change the patient id for those test cases.