Skip to content

Real submit data option - #112

Merged
elsaperelli merged 1 commit into
mainfrom
real-submit-data
Sep 9, 2025
Merged

Real submit data option#112
elsaperelli merged 1 commit into
mainfrom
real-submit-data

Conversation

@lmd59

@lmd59 lmd59 commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Summary

Add option for the "Submit Data" button to allow either a "proto" submit data (just POST the transaction bundles) or a real submit data that uses the appropriate endpoint.

New Behavior

"Submit Data" button has two options. The "POST data" option will do the "proto" version, and the "$submit-data" will do the full deqm option.

Code Changes

  • All changes are updates to PopulationCalculation.tsx to make the UI change and update the submitDataToEvaluationService function to be flexible around which option it's using (both use transaction bundles).

Testing Guidance

  • npm run check
  • PORT=3001 npm run dev
  • Start the deqm-test-server local instance (npm run start)
  • Load a measure that is in the deqm-test-server instance (default ecqm-content-r4-2021 measures, I used CervicalCancerScreening)
  • Use http://localhost:3000/4_0_1 for the Evaluation Service URL and click "Verify" then "Next"
  • Load some test cases
  • Choose the "Submit Data" dropdown from the bottom left and experiment with choosing either option. Observe requests sent in the chrome network tab. The "$submit-data" option should send one fetch to the server, whereas the "POST data" option will do a fetch for each patient.
  • To observe a change on the server-side, you can change the id of one of the patients, use the $submit-data option, and observe the patient count on the server going up.

@elsaperelli
elsaperelli self-requested a review September 8, 2025 18:07
@elsaperelli elsaperelli self-assigned this Sep 8, 2025

@elsaperelli elsaperelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! UI expertise!

@elsaperelli
elsaperelli merged commit a5b6330 into main Sep 9, 2025
1 check passed
@elsaperelli
elsaperelli deleted the real-submit-data branch September 9, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants