Subject group - #113
Merged
Merged
Conversation
zacharyrobin
approved these changes
Sep 11, 2025
zacharyrobin
left a comment
Contributor
There was a problem hiding this comment.
Tested with deqm-test-server looks good. There is the one error of "cannot read properties of undefined (reading 'operand')" but thats on main as well and is unrelated to these code changes.
For testing:
Population : none, all both work but patients do not.
Subject : patients works but none and all do not.
Which I believe is what you are expecting on your end.
Contributor
|
The other thing which may be nice in a future update is to increase the size of the window of the popup so that you dont have to scroll as much to see what is returned by the server. |
Contributor
Author
This seems to be an environment issue of some sort since I'm not seeing it on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an "All" option to the evaluate subject list which is implemented using the subjectGroup parameter.
New Behavior
When the user selects the All subject option, they should be able to see subjectGroup results where the subjectGroup is created with all loaded test cases. Additionally, the user may do either population or subject reportType evaluation with an optional subject chosen from the dropdown.
Code Changes
All code changes are in
PopulationCalculation.tsxwhich expands the subject dropdown to include the "All" option and adds subject parameters appropriately when calling the server $evaluate operation. Changes in the Select component no longer disable the subject dropdown for population reporting and also allow the subject to be cleared (for a full server option).Testing Guidance
npm run checkPORT=3001 npm run devnpm run db:resetnpm run upload-bundles [bundles path](ecqm-content-cms-2025)npm run start)If updated, also consider testing with the flame-demo server