Skip to content

Subject group - #113

Merged
lmd59 merged 3 commits into
mainfrom
subjectGroup
Sep 11, 2025
Merged

Subject group#113
lmd59 merged 3 commits into
mainfrom
subjectGroup

Conversation

@lmd59

@lmd59 lmd59 commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Summary

Adds an "All" option to the evaluate subject list which is implemented using the subjectGroup parameter.

New Behavior

When the user selects the All subject option, they should be able to see subjectGroup results where the subjectGroup is created with all loaded test cases. Additionally, the user may do either population or subject reportType evaluation with an optional subject chosen from the dropdown.

Code Changes

All code changes are in PopulationCalculation.tsx which expands the subject dropdown to include the "All" option and adds subject parameters appropriately when calling the server $evaluate operation. Changes in the Select component no longer disable the subject dropdown for population reporting and also allow the subject to be cleared (for a full server option).

Testing Guidance

  • npm run check
  • PORT=3001 npm run dev
  • Pull the deqm-test-server branch here if not yet merged subjectGroup parameter for $evaluate operation deqm-test-server#170
  • Load the CMS connectathon measures (recommended to have better data to work with than the 2021 measures)...
  • npm run db:reset
  • npm run upload-bundles [bundles path] (ecqm-content-cms-2025)
  • Start the deqm-test-server local instance (npm run start)
  • In fqm-testify, load a measure that is in the deqm-test-server instance (I used CMS506)
  • Use http://localhost:3000/4_0_1 for the Evaluation Service URL and click "Verify" then "Next"
  • Load some test cases (recommend partial to be able to easily compare with full server evaluate)
  • Choose the "Submit Data" dropdown from the bottom left (either option should be fine)
  • Choose the "Evaluate" button
  • Experiment with the population report type combined with the "All" subject (which creates a subjectGroup for all of the loaded patients)
  • Make sure other population report type options still work
  • You can also experiment with the subject report type, but the subjectGroup "All" option for subject report type is not yet implemented on the server

If updated, also consider testing with the flame-demo server

@zacharyrobin zacharyrobin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with deqm-test-server looks good. There is the one error of "cannot read properties of undefined (reading 'operand')" but thats on main as well and is unrelated to these code changes.
For testing:
Population : none, all both work but patients do not.
Subject : patients works but none and all do not.

Which I believe is what you are expecting on your end.

@zacharyrobin

Copy link
Copy Markdown
Contributor

The other thing which may be nice in a future update is to increase the size of the window of the popup so that you dont have to scroll as much to see what is returned by the server.

@lmd59

lmd59 commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

cannot read properties of undefined (reading 'operand')

This seems to be an environment issue of some sort since I'm not seeing it on my end.

@lmd59
lmd59 merged commit b393a84 into main Sep 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants