This repository was archived by the owner on May 24, 2020. It is now read-only.
Take in account marked for removal kernels. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation how many kernels to remove before this commit was not taking in account kernels which are already marked for removal. Thus when adding new kernels for removal the logic would end up removing more than the user requested. This commit just adds the already marked for removal kernels to the calculation. Should fix projg2#15.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation how many kernels to remove before this commit was not
taking in account kernels which are already marked for removal. Thus
when adding new kernels for removal the logic would end up removing more
than the user requested.
This commit just adds the already marked for removal kernels to the
calculation.
Should fix #15.