Open
Conversation
longlene
commented
Apr 21, 2024
- init:stop should be after eval expression
- erl_interface is deprected
init:stop should be after eval expression
|
Can this one being merged? |
Member
|
@longlene is this PR still valid? What do you mean by erl_interface being deprecated, and if so, how can we remove it entirely? Please rebase the branch on top of the latest master if you'd have some time :) |
Author
|
@NelsonVides Yes, the |
Member
|
I've ran master on both OTP27 and OTP28 in both ubuntu and macos and it "just runs ok", the package builds and metrics are collected fine. Where did you reproduce the issue? Also, in your changes I've seen there's only the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.