Skip to content

Allow Exemplars on all time series #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fstab
Copy link
Member

@fstab fstab commented Feb 26, 2024

At the Prometheus dev summit on 2022-11-10 there was consensus that

Prometheus will ingest Exemplars on all time series.

Previously exemplars were only allowed for counters and histogram buckets.

The change has been implemented in the Prometheus server and was merged on Mar 5, 2023 with prometheus/prometheus#11984.

This PR updates the OpenMetrics spec to explicity allow exemplars on all time series.

This is not a breaking change for client libraries producing OpenMetrics text format. Exemplars are optional, and time series without exemplars are of course still valid.

It might however break scrapers parsing OpenMetrics if these scrapers verify that exemplars can only be present for counters and histogram buckets.

Because of the potential breaking change, we create a new version 1.1.0 with this PR.

@MaxGabriel
Copy link

Hi, is the plan to merge this? Saw it was sitting with one approval and was wondering if the consensus changed on it or something

(was working on a client library and figuring out what metrics to support exemplars for)

@jonatan-ivanov
Copy link

@MaxGabriel I'm not part of the approvers but the Prometheus server already has this capability; if your client library provides exemplars you should see them on the backend, see: prometheus/prometheus#11984
(Not sure about non-Prometheus backends.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants