feat(api/prometheus): add format_query endpoint for query formatting #1846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshngg
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
The changes introduce a new `/format_query` API endpoint to handle query formatting in the Prometheus API. This includes implementing the `FormatQuery` function in `api.go` and adding corresponding test cases in `api_test.go` to ensure proper functionality. Signed-off-by: yshngg <[email protected]>
yshngg
force-pushed
the
feature/format-query
branch
from
4c76b54 to
1be9221
Compare
Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Yusheng Guo <[email protected]>
bwplotka
approved these changes
Aug 20, 2025
|
Ah I missed this, but we need to add this method to our unfortunate interface https://github.com/yshngg/client_golang/blob/83a97306104f6a869e14b28363d63b256c484c84/api/prometheus/v1/api.go#L464 (unfortunate because we should not have it, especially so large - maybe we can remove it one day) |
|
Understood — my apologies, I missed that as well. I’ll reopen a new Pull Request to add the FormatQuery method to the API interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduce a new
/format_queryAPI endpoint to handle query formatting in the Prometheus API.This includes implementing the
FormatQueryfunction inapi.goand adding corresponding test cases inapi_test.goto ensure proper functionality.Fix #1845