om2: MetricFamilyName is MetricName#2791
Merged
Merged
Conversation
Member
Author
|
I am bit surprised but I couldn't find any special rule for those suffixes in the ABNF to change... also tests passes despite me adding suffixes to MF names. Something smells like ABNF is too relaxed. |
ArthurSens
reviewed
Dec 3, 2025
ArthurSens
left a comment
ArthurSens
left a comment
Member
There was a problem hiding this comment.
I could review only half of the PR 😬, I have some small comments
bwplotka
commented
Dec 3, 2025
bwplotka
commented
Dec 3, 2025
bwplotka
commented
Dec 3, 2025
bwplotka
commented
Dec 3, 2025
dashpole
reviewed
Dec 3, 2025
Member
|
do we still intend to merge this? |
bwplotka
force-pushed
the
bwplotka/om2-restr
branch
6 times, most recently
from
11a31fa to
ff36b8d
Compare
Member
Author
|
I think so. Much simpler now with Composite Types merged in. |
Member
Author
|
PTAL @krajorama @dashpole @ywwg |
bwplotka
commented
Feb 10, 2026
bwplotka
commented
Feb 10, 2026
krajorama
reviewed
Feb 10, 2026
Fixes prometheus/OpenMetrics#305 Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/om2-restr
branch
from
ff36b8d to
70aa8d3
Compare
dashpole
previously approved these changes
Feb 10, 2026
ywwg
reviewed
Feb 10, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
commented
Feb 11, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
commented
Feb 18, 2026
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
dashpole
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes prometheus/OpenMetrics#305
We can either merge this with TODOs before complex values/types or wait for complex type/values.