Assessment: Show completion and results diagrams on evaluation overview pages#1913
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughChangesEvaluation analytics
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant TutorOverviewPage
participant useGetAllEvaluations
participant AssessmentAPI
participant getScoreLevelsFromEvaluations
participant AnalyticsDiagrams
TutorOverviewPage->>useGetAllEvaluations: load evaluations for phaseId
useGetAllEvaluations->>AssessmentAPI: request phase evaluations
AssessmentAPI-->>useGetAllEvaluations: return Evaluation[]
TutorOverviewPage->>getScoreLevelsFromEvaluations: compute tutor score levels
TutorOverviewPage->>AnalyticsDiagrams: render participations, completions, and score levels
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rappm
changed the title
Assessment: Show assessment diagrams on evaluation overview pagesAssessment: Show completion and results diagrams on evaluation overview pages
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
clients/assessment_component/src/assessment/pages/components/diagrams/AssessmentDiagram.tsx (1)
34-36: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDecouple
completionstype fromCompetencyScoreCompletion.Since
participationswas broadened to an inline generic type and this component is now used withEvaluationCompletiondata,completionsshould also be broadened. This avoids type mismatches and decouples the component from specific domain interfaces.♻️ Proposed refactor
participations: Array<{ courseParticipationID: string }> scoreLevels: ScoreLevelWithParticipation[] - completions: CompetencyScoreCompletion[] + completions: Array<{ courseParticipationID: string; completed?: boolean }>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@clients/assessment_component/src/assessment/pages/components/diagrams/AssessmentDiagram.tsx` around lines 34 - 36, Update the AssessmentDiagram component’s completions prop type to use an inline generic shape containing only the fields this component consumes, rather than CompetencyScoreCompletion. Ensure it accepts EvaluationCompletion data while preserving the existing completion-handling behavior and remove the unnecessary domain-interface coupling.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@clients/assessment_component/src/assessment/pages/TutorOverviewPage/TutorOverviewPage.tsx`:
- Around line 31-34: Update the useQuery call in TutorOverviewPage to add
enabled: !!phaseId, preventing requests when phaseId is unavailable. Define a
stable module-level empty completions constant typed as EvaluationCompletion[]
and use it instead of the inline [] data fallback, adding the required
EvaluationCompletion import so tutorEvaluationCompletions retains memoization.
---
Nitpick comments:
In
`@clients/assessment_component/src/assessment/pages/components/diagrams/AssessmentDiagram.tsx`:
- Around line 34-36: Update the AssessmentDiagram component’s completions prop
type to use an inline generic shape containing only the fields this component
consumes, rather than CompetencyScoreCompletion. Ensure it accepts
EvaluationCompletion data while preserving the existing completion-handling
behavior and remove the unnecessary domain-interface coupling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 74eb3d29-255e-457f-aed1-33e9c6393b3d
📒 Files selected for processing (7)
clients/assessment_component/src/assessment/network/queries/getAllEvaluations.tsclients/assessment_component/src/assessment/pages/EvaluationParticipantResultsPage/EvaluationParticipantsOverviewPage.tsxclients/assessment_component/src/assessment/pages/TutorOverviewPage/TutorOverviewPage.tsxclients/assessment_component/src/assessment/pages/components/diagrams/AssessmentDiagram.tsxclients/assessment_component/src/assessment/pages/components/diagrams/ScoreLevelDistributionDiagram.tsxclients/assessment_component/src/assessment/pages/hooks/useGetAllEvaluations.tsclients/assessment_component/src/assessment/pages/utils/getScoreLevelsFromEvaluations.ts
mathildeshagl
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Template
Use this template to provide all necessary information for reviewing and testing your changes. closes #755
✨ What is the change?
Adds assessment-style diagrams to the top of the three lecturer evaluation overview pages (Tutor Overview, Self Evaluations, Peer Evaluations):
AssessmentDiagram) used on the Assessment Participants page, fed each page'sAssessmentType-filteredEvaluationCompletion[].ScoreLevelDistributionDiagram) used on the Assessment Statistics page, fed a per-participant aggregate score level computed from all evaluations of that type.The per-participant aggregate reuses the existing bulk endpoint
GET /course_phase/{id}/evaluation(getAllEvaluationsByPhase) via a newgetAllEvaluationsquery/useGetAllEvaluationshook, and agetScoreLevelsFromEvaluationsutil that groups evaluations by target participant and averages their score levels with the sharedmapScoreLevelToNumber/mapNumberToScoreLevelhelpers.AssessmentDiagramandScoreLevelDistributionDiagramwere minimally generalized (broadenedparticipationsto a structural shape;AssessmentDiagramgainedTUTORlabels;ScoreLevelDistributionDiagramgained optionaltitle/description) rather than duplicated. Existing callers are unchanged.📌 Reason for the change / Link to issue
Closes #868 and #755. The evaluation overview pages showed only tables; lecturers had no at-a-glance view of completion and results. Grade-distribution diagrams are intentionally omitted for evaluations because evaluations have no grade suggestion (that is assessment-only).
🧪 How to Test
cd clients/assessment_component && npx tsc --noEmit -p tsconfig.jsonandnpx biome checkon the changed files pass.🖼️ Screenshots (if UI changes are included)
✅ PR Checklist
Summary by CodeRabbit