Core: Add gender, study degree and nationality as hidden columns to student table. Add Full Name column#1933
Conversation
…ll name column for easy search
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe student course participation query and API now include gender, nationality, and study degree. The client consumes these fields, and the management table adds corresponding optional columns alongside a computed full-name column. ChangesStudent profile field propagation
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant StudentTable
participant getStudentsWithCourses
participant StudentWithCourseParticipationsDTO
participant GetAllStudentsWithCourseParticipations
StudentTable->>getStudentsWithCourses: request students with courses
getStudentsWithCourses->>StudentWithCourseParticipationsDTO: receive expanded response
StudentWithCourseParticipationsDTO->>GetAllStudentsWithCourseParticipations: map student profile fields
getStudentsWithCourses-->>StudentTable: return profile and course data
StudentTable->>StudentTable: render optional profile columns
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@clients/core/src/managementConsole/shared/components/StudentTable/studentTableColumns.tsx`:
- Around line 45-47: Correct the full-name accessorFn to concatenate
row.firstName and row.lastName once each, removing the duplicated trailing
row.firstName while preserving the existing spacing and StudentWithCourses row
handling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fad128f4-aea8-4aa7-b75c-492aac29b4da
📒 Files selected for processing (9)
clients/core/src/managementConsole/shared/components/StudentTable/StudentTable.tsxclients/core/src/managementConsole/shared/components/StudentTable/studentTableColumns.tsxclients/core/src/network/queries/getStudentsWithCourses.tsservers/core/db/query/students.sqlservers/core/db/sqlc/students.sql.goservers/core/docs/docs.goservers/core/docs/swagger.jsonservers/core/docs/swagger.yamlservers/core/student/studentDTO/get_students_with_courses.go
…-in-the-core-studenttable
|
Functionality wise it alr works, one linter is still failing though @JGStyle apart from that would be good to go for me |
✨ What is the change?
This PR adds the columns
gender,study degreeandnationalityto the student table. The query and dtos have been adjusted accordinglyI also added a column 'Full Name' which combines First and last name. This lets you search a student by full name (until now only first or last name was possible, due to those being separate columns) this column does not have to be visible for the search to work.
All of the added columns are hidden by default.
📌 Reason for the change / Link to issue
implements #1930
🧪 How to Test
Open the student table and inspect the columns
🖼️ Screenshots (if UI changes are included)
✅ PR Checklist
Summary by CodeRabbit