Skip to content

Core: Add gender, study degree and nationality as hidden columns to student table. Add Full Name column#1933

Open
JGStyle wants to merge 4 commits into
mainfrom
1930-be-able-to-show-more-info-from-students-in-the-core-studenttable
Open

Core: Add gender, study degree and nationality as hidden columns to student table. Add Full Name column#1933
JGStyle wants to merge 4 commits into
mainfrom
1930-be-able-to-show-more-info-from-students-in-the-core-studenttable

Conversation

@JGStyle

@JGStyle JGStyle commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

✨ What is the change?

This PR adds the columns gender, study degree and nationality to the student table. The query and dtos have been adjusted accordingly

I also added a column 'Full Name' which combines First and last name. This lets you search a student by full name (until now only first or last name was possible, due to those being separate columns) this column does not have to be visible for the search to work.

All of the added columns are hidden by default.

📌 Reason for the change / Link to issue

implements #1930

🧪 How to Test

Open the student table and inspect the columns

🖼️ Screenshots (if UI changes are included)

2026-07-15 at 20 48 11 2026-07-15 at 20 48 25 2026-07-15 at 20 48 58

✅ PR Checklist

  • Tested locally or on the dev environment
  • Code is clean, readable, and documented
  • Tests added or updated (if needed)
  • Screenshots attached for UI changes (if any)
  • Documentation updated (if relevant)

Summary by CodeRabbit

  • New Features
    • Added student profile fields (gender, nationality, study degree, and full name) to student-with-courses data.
    • Updated the API responses and Swagger documentation to expose the new fields.
    • Extended the student table to support these attributes in the table’s columns and filtering/sorting where applicable.
  • UI Improvements
    • The student table now hides the gender, study degree, nationality, and full name columns by default; they can be enabled from column visibility settings.

@JGStyle
JGStyle requested a review from a team July 15, 2026 18:49
@JGStyle JGStyle linked an issue Jul 15, 2026 that may be closed by this pull request
@JGStyle JGStyle self-assigned this Jul 15, 2026
@JGStyle JGStyle added the Component: Core Issues related to the prompt core label Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: efb5b76e-d031-41cf-8d62-6eb82edc1b5b

📥 Commits

Reviewing files that changed from the base of the PR and between d1bf47d and fcd54bd.

📒 Files selected for processing (2)
  • clients/core/src/managementConsole/shared/components/StudentTable/StudentTable.tsx
  • clients/core/src/managementConsole/shared/components/StudentTable/studentTableColumns.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • clients/core/src/managementConsole/shared/components/StudentTable/studentTableColumns.tsx
  • clients/core/src/managementConsole/shared/components/StudentTable/StudentTable.tsx

📝 Walkthrough

Walkthrough

The student course participation query and API now include gender, nationality, and study degree. The client consumes these fields, and the management table adds corresponding optional columns alongside a computed full-name column.

Changes

Student profile field propagation

Layer / File(s) Summary
Database query and generated row mapping
servers/core/db/query/students.sql, servers/core/db/sqlc/students.sql.go
The query selects and groups additional student fields, while the generated row type and scan mapping expose them with student_* names.
DTO mapping and API schema
servers/core/student/studentDTO/..., servers/core/docs/...
The API DTO maps gender, nationality, and study degree, and the generated Swagger definitions describe the expanded response schema.
Client response type and fetch path
clients/core/src/network/queries/getStudentsWithCourses.ts
StudentWithCourses includes the new fields, and the existing request returns the expanded response data.
Student table columns and visibility
clients/core/src/managementConsole/shared/components/StudentTable/...
The table adds full name, study degree, gender, and nationality columns, with all four hidden by default; existing course, tag, date, and deletion behavior remains in place.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant StudentTable
  participant getStudentsWithCourses
  participant StudentWithCourseParticipationsDTO
  participant GetAllStudentsWithCourseParticipations
  StudentTable->>getStudentsWithCourses: request students with courses
  getStudentsWithCourses->>StudentWithCourseParticipationsDTO: receive expanded response
  StudentWithCourseParticipationsDTO->>GetAllStudentsWithCourseParticipations: map student profile fields
  getStudentsWithCourses-->>StudentTable: return profile and course data
  StudentTable->>StudentTable: render optional profile columns
Loading

Possibly related PRs

  • prompt-edu/prompt#804: Adds related study program and study degree columns with study degree hidden by default.
  • prompt-edu/prompt#1680: Modifies the same student-table components for admin-driven deletion behavior.

Suggested reviewers: mtze

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: hidden student columns plus the new Full Name column.
Description check ✅ Passed The description follows the template with change, reason, testing, screenshots, and checklist sections filled in.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 1930-be-able-to-show-more-info-from-students-in-the-core-studenttable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@clients/core/src/managementConsole/shared/components/StudentTable/studentTableColumns.tsx`:
- Around line 45-47: Correct the full-name accessorFn to concatenate
row.firstName and row.lastName once each, removing the duplicated trailing
row.firstName while preserving the existing spacing and StudentWithCourses row
handling.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fad128f4-aea8-4aa7-b75c-492aac29b4da

📥 Commits

Reviewing files that changed from the base of the PR and between 3d55015 and d1bf47d.

📒 Files selected for processing (9)
  • clients/core/src/managementConsole/shared/components/StudentTable/StudentTable.tsx
  • clients/core/src/managementConsole/shared/components/StudentTable/studentTableColumns.tsx
  • clients/core/src/network/queries/getStudentsWithCourses.ts
  • servers/core/db/query/students.sql
  • servers/core/db/sqlc/students.sql.go
  • servers/core/docs/docs.go
  • servers/core/docs/swagger.json
  • servers/core/docs/swagger.yaml
  • servers/core/student/studentDTO/get_students_with_courses.go

@JGStyle JGStyle added the schau mi o Translation: Ready to review label Jul 15, 2026
@rappm

rappm commented Jul 16, 2026

Copy link
Copy Markdown
Member

Functionality wise it alr works, one linter is still failing though @JGStyle apart from that would be good to go for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Core Issues related to the prompt core schau mi o Translation: Ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be able to show more info from students in the Core StudentTable

2 participants