PR depends on previous PR;Add greedy matching strategy explanation to constraint summary UI#288
Open
mehdo14 wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explanation panel to the constraint summary overlay for the company-greedy matching workflow.
When the current course uses greedy matching, the UI now shows a short description explaining that the system matches step by step using priority tiers, is fast for larger datasets, and may not produce the globally optimal overall solution. LP behavior and UI remain unchanged.
Changes
Add matchingMode state to ConstraintSummaryComponent.
Determine matching mode on init via MatchingRouterService.
Add isCompanyGreedyMode helper for template rendering.
Render a greedy-only informational note in the constraint summary overlay.
Add styling for the strategy note to present it as contextual guidance.
Why
The greedy workflow behaves differently from the LP-based matching flow, so users should understand the tradeoff before. clicking Distribute Teams. This adds that context at the point of action without changing the LP experience.