Skip to content

Fix sed substitution of {{TOPIC}} mangling/breaking on special chars #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skytow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix sed substitution of {{TOPIC}} mangling/breaking on special chars #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions plugins/claudex/scripts/start-loop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,14 @@ decision_signal: none"
claudex_state_write "$STATE_FILE" "$STATE_CONTENT" || exit 3
claudex_lock_write "$LOCK_FILE" || exit 3

# {{TOPIC}} is substituted into the prompt templates via sed below. The topic is
# user-provided and may contain characters that are special in a sed replacement:
# backslash, "&" (means "the whole matched text", i.e. "{{TOPIC}}"), and the "|"
# delimiter. Escape all three so the literal topic is inserted verbatim, and
# collapse newlines since sed operates line-by-line. (REVIEW_ID and MAX_ROUNDS are
# a generated id and an integer, so they need no escaping.)
SED_SAFE_TOPIC="$(printf '%s' "$TOPIC" | tr '\n\r' ' ' | sed -e 's/[\\&|]/\\&/g')"

# Print initial instructions to stdout. Claude will read these.
case "$MODE" in
plan)
Expand All @@ -196,13 +204,13 @@ case "$MODE" in
echo "Source: existing PLAN.md (--from-draft)"
echo ""
cat "$CLAUDE_PLUGIN_ROOT/scripts/prompts/plan-mode-from-draft.md" 2>/dev/null \
| sed -e "s|{{TOPIC}}|$TOPIC|g" -e "s|{{REVIEW_ID}}|$REVIEW_ID|g" -e "s|{{MAX_ROUNDS}}|$MAX_ROUNDS|g"
| sed -e "s|{{TOPIC}}|$SED_SAFE_TOPIC|g" -e "s|{{REVIEW_ID}}|$REVIEW_ID|g" -e "s|{{MAX_ROUNDS}}|$MAX_ROUNDS|g"
else
echo ""
echo "Round 1 - drafting plan."
echo ""
cat "$CLAUDE_PLUGIN_ROOT/scripts/prompts/plan-mode-init.md" 2>/dev/null \
| sed -e "s|{{TOPIC}}|$TOPIC|g" -e "s|{{REVIEW_ID}}|$REVIEW_ID|g"
| sed -e "s|{{TOPIC}}|$SED_SAFE_TOPIC|g" -e "s|{{REVIEW_ID}}|$REVIEW_ID|g"
fi
;;
review)
Expand Down