Skip to content

fix: reject undersized nested pickle budgets #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mldangelo-oai merged 1 commit into from
Jun 9, 2026
Merged

fix: reject undersized nested pickle budgets #1532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modelaudit/scanners/picklescan_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def scan_options_from_config(config: Mapping[str, Any]) -> ScanOptions:
_DEFAULT_SCAN_OPTIONS.max_nested_pickle_bytes,
),
_DEFAULT_SCAN_OPTIONS.max_nested_pickle_bytes,
minimum=0,
minimum=2,
),
max_nested_depth=_parse_min_int(
config.get(
Expand Down
1 change: 1 addition & 0 deletions packages/modelaudit-picklescan/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ and this package adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Bug Fixes

- reject nested-pickle analysis budgets below two bytes, recognize explicit protocol 0 headers, and use bounded structural probes to avoid prose false positives without missing valid suffixes
- preserve fail-closed nested protocol 0 analysis after `INST` opcodes
- fail closed when known-size pickle boundaries cannot be verified or contain trailing bytes, and bind file scans to one descriptor
- fail closed before copying protocol 0 line operands larger than 8 MiB
Expand Down
Loading
Loading