Skip to content

Adding JWT fetch during health check for server connection#208

Merged
avalerio-tkd merged 2 commits intomainfrom
av_add_auth_to_init_023
Jan 24, 2026
Merged

Adding JWT fetch during health check for server connection#208
avalerio-tkd merged 2 commits intomainfrom
av_add_auth_to_init_023

Conversation

@avalerio-tkd
Copy link
Collaborator

  • Added eager JWT fetching to DBPSApiClient::HealthCheck()
  • Added unittest.

@avalerio-tkd
Copy link
Collaborator Author

avalerio-tkd commented Jan 24, 2026

@argmarco-tkd I tested the change in a couple ways and it looks fine (also added the unittest). Only if this only takes a few minutes, can you check if this behaves as expected on the testing you made before? If this takes longer than a few minutes to test, it should be fine to skip it. Thanks!

@argmarco-tkd
Copy link
Collaborator

argmarco-tkd commented Jan 24, 2026

@argmarco-tkd I tested the change in a couple ways and it looks fine (also added the unittest). Only if this only takes a few minutes, can you check if this behaves as expected on the testing you made before? If this takes longer than a few minutes to test, it should be fine to skip it. Thanks!

Ran tests from the av_add_auth_to_init_023 branch for the DBPS server.

When passing no credentials, and when using the wrong credentials, I got the following error Arrow side (I think this is expected):

/arrowdev/cpp/src/parquet/encryption/external/dbpa_executor.cc:101: [DBPAExecutor] EXCEPTION: init failed with: Health check failed: Health check succeeded but JWT fetch failed:  (status code: 401)
terminate called after throwing an instance of 'DBPSException'
  what():  Health check failed: Health check succeeded but JWT fetch failed:  (status code: 401)
Aborted

Things worked properly when passing the right credentials.

Copy link
Collaborator

@argmarco-tkd argmarco-tkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - performed some testing, things behaved as-expected.

@avalerio-tkd
Copy link
Collaborator Author

Awesome. Thanks for checking this.

- Updating working branch with main.
@avalerio-tkd avalerio-tkd merged commit a1a91a9 into main Jan 24, 2026
2 checks passed
@avalerio-tkd avalerio-tkd deleted the av_add_auth_to_init_023 branch January 24, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants