Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not play with mutable data #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nogenhat
Copy link

@nogenhat nogenhat commented Apr 7, 2015

There can be issues, when you force encode original string into binary and then someone else want to use this string.

@fl00r
Copy link

fl00r commented Apr 7, 2015

I believe the problem is here

def append_string(s)

@bkerley
Copy link
Member

bkerley commented May 22, 2015

Is there a way to write a test for this?

@bkerley
Copy link
Member

bkerley commented Jun 7, 2016

This is closely related to but distinct from #69 and #70 .

That is all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants