Add nested enum descriptor in php rumtime. (#3009)

protocolbuffers · Apr 24, 2017 · fba2acd · fba2acd
1 parent e64b618
commit fba2acd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/php/src/Google/Protobuf/Internal/DescriptorPool.php b/php/src/Google/Protobuf/Internal/DescriptorPool.php
@@ -95,6 +95,9 @@ public function addDescriptor($descriptor)
         foreach ($descriptor->getNestedType() as $nested_type) {
             $this->addDescriptor($nested_type);
         }
+        foreach ($descriptor->getEnumType() as $enum_type) {
+            $this->addEnumDescriptor($enum_type);
+        }
     }
 
     public function addEnumDescriptor($descriptor)

diff --git a/php/src/Google/Protobuf/descriptor.php b/php/src/Google/Protobuf/descriptor.php
@@ -210,6 +210,12 @@ public static function buildFromProto($proto, $file_proto, $containing)
               $nested_proto, $file_proto, $message_name_without_package));
         }
 
+        // Handle nested enum.
+        foreach ($proto->getEnumType() as $enum_proto) {
+            $desc->addEnumType(EnumDescriptor::buildFromProto(
+              $enum_proto, $file_proto, $message_name_without_package));
+        }
+
         // Handle oneof fields.
         foreach ($proto->getOneofDecl() as $oneof_proto) {
             $desc->addOneofDecl(

diff --git a/php/tests/generated_class_test.php b/php/tests/generated_class_test.php
@@ -839,7 +839,8 @@ public function testMessageMergeFromInvalidTypeFail()
     public function testMessageWithoutNamespace()
     {
         $m = new TestMessage();
-        $m->setOptionalNoNamespaceMessage(new NoNameSpaceMessage());
+        $sub = new NoNameSpaceMessage();
+        $m->setOptionalNoNamespaceMessage($sub);
         $m->getRepeatedNoNamespaceMessage()[] = new NoNameSpaceMessage();
 
         $n = new NoNamespaceMessage();