Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Add loadBalancerIP attribute for LB svc #3795

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

nbouron
Copy link
Contributor

@nbouron nbouron commented May 9, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

In some cases we need to set the loadBalancerIP with a preprovisioned IP in case of a service of type LoadBalancer, this is why i created this PR.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

Please Merge Me

@nbouron nbouron requested a review from a team as a code owner May 9, 2023 15:18
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there nbouron! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@Haarolean Haarolean added the scope/k8s K8s or helm stuff (really annoying) label May 10, 2023
@Haarolean Haarolean added the type/enhancement En enhancement to an already existing feature label May 10, 2023
Copy link
Collaborator

@Narekmat Narekmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nbouron. Thank you for your changes.
Please fix versions in Charts.yaml.
-appversion must stay v0.6.2 and -version must be 0.6.3

@nbouron
Copy link
Contributor Author

nbouron commented May 10, 2023

Thank you for your return. Versions have been fixed in charts.yaml

@Narekmat
Copy link
Collaborator

@nbouron please keep appversion v0.6.2

@nbouron
Copy link
Contributor Author

nbouron commented May 10, 2023

Sorry for the mistake, the explanation was clear, it's fixed !

@Haarolean Haarolean added this to the 0.8 milestone May 11, 2023
@Haarolean
Copy link
Contributor

@nbouron can you rebase please?

@Haarolean Haarolean requested a review from Narekmat May 18, 2023 08:34
@Haarolean
Copy link
Contributor

@nbouron the build will fail until the template checkboxes are filled correctly, can you fix that as well?

@nbouron
Copy link
Contributor Author

nbouron commented May 18, 2023

Fixed

@Haarolean Haarolean changed the title feat(charts/kafka-ui): add loadBalancerIP attribute for LB svc Helm: Add loadBalancerIP attribute for LB svc May 18, 2023
@Haarolean Haarolean enabled auto-merge (squash) May 18, 2023 09:40
@Haarolean Haarolean disabled auto-merge June 20, 2023 04:17
@Haarolean Haarolean merged commit c998e17 into provectus:master Jun 20, 2023
4 checks passed
@Haarolean
Copy link
Contributor

@nbouron thank you for the contribution!

@Haarolean Haarolean removed this from the 0.8 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/k8s K8s or helm stuff (really annoying) type/enhancement En enhancement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants