-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: Add loadBalancerIP attribute for LB svc #3795
Conversation
Signed-off-by: Nicolas BOURON <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there nbouron! 👋
Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖
We will try to review it soon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @nbouron. Thank you for your changes.
Please fix versions in Charts.yaml.
-appversion must stay v0.6.2 and -version must be 0.6.3
Signed-off-by: Nicolas BOURON <[email protected]>
Thank you for your return. Versions have been fixed in charts.yaml |
@nbouron please keep appversion v0.6.2 |
Signed-off-by: Nicolas BOURON <[email protected]>
Sorry for the mistake, the explanation was clear, it's fixed ! |
@nbouron can you rebase please? |
@nbouron the build will fail until the template checkboxes are filled correctly, can you fix that as well? |
Fixed |
@nbouron thank you for the contribution! |
What changes did you make? (Give an overview)
In some cases we need to set the loadBalancerIP with a preprovisioned IP in case of a service of type LoadBalancer, this is why i created this PR.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)